IP-895: Option to Initiate Terms When Sending Invoice #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdrost7
changed the title
|
@Verony-makesIT reopened the PR, is it still WIP or can we merge it? |
nielsdrost7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #924 --> must reopen it to re-revert
Description
As indicated in the problem (#895), when sending the invoice, the invoice date and due date are not changed.
Those details are retained as set when the invoice is created, even if changes are made in the period (days, weeks) thereafter.
My solution will always "by default" change the invoice date to the current date and also recalculate the due date, IF the setting [Disable the change of invoice date and due date before emailing] is NOT activated BEFORE SENDING THE EMAIL!
So if the setting is active then the invoice date and due date are NOT changed.
Related Issue
#895
Motivation and Context
For me, this is a problem/rectification that needs to be resolved
#895
Screenshots (if appropriate):
Pull Request Checklist
Issue Type (Please check one or more)