Skip to content
This repository has been archived by the owner on Dec 31, 2019. It is now read-only.

Alpha 5 #80

Merged
merged 40 commits into from
Dec 10, 2014
Merged

Alpha 5 #80

merged 40 commits into from
Dec 10, 2014

Conversation

602p
Copy link
Collaborator

@602p 602p commented Dec 9, 2014

This pull request includes your Alpha 5 changes, as well as:

  • FailureModules have customizable calls to DI_ShowInfoInEditor to determine if they should be shown in the ReliabilityInfo pane
  • FailureModules have the attribute ExtraEditorInfo that is inserted into the ReliabilityInfo pane
  • Import ModuleIntakeReliability to DangIt! core (closes Air intakes clogging #24)
  • Import ModuleCoolantReliability to DangIt! core (closes LOCA Failure #22)
  • Add ExtraEditorInfo to all FailureModules
  • ModuleTankReliability now implements DI_ShowInfoInEditor in such a way that it does not appear if there are no leakable resources (closes The tank module is applied to batteries #28)
  • Adds sounds notifications (closes Sound notifications #17)
  • Adds customization GUI for sounds (disable, set # repeats)
  • Implements KSPAssembley (starting from version 0.5.0)

Tell me what you think @Ippo343

P.S. I'm sorry I made a mess of branches, in the future I'll fork the right one (or better, add me as a collaborator so I can edit the indev branch)

Ippo343 and others added 30 commits November 20, 2014 00:48
Adds an API pure-reflection hook, and a method to count failures as a
starting point.
Makes the leaks black list a static property so that it can be called
whenever it is needed (it didn't need the instance anyway).
Merge my changes back to master
Users will have to update entropy to use DangIt! Alpha 5
@Ippo343
Copy link
Owner

Ippo343 commented Dec 9, 2014

OH MY GOD MAN! You are AWESOME! :D
Give me some time to take a good look at the code and I'll get back to you! :)

@602p
Copy link
Collaborator Author

602p commented Dec 9, 2014

P.P.S. I may have damaged your project files (.sln and stuff) because you use Visual Studio (I think) and I use Xamarin. If you want to revert that, thats fine, I've figured out how to have it as an include. 😄

@602p
Copy link
Collaborator Author

602p commented Dec 9, 2014

No pull yet: a few things that should be done first...

  • Check for other things that should be hidden in editor
  • Implement ModuleNoFailures to the rest of the mm CFGs in the DangIt core (system I started using in Entropy so mod authors can blacklist adding failures to parts)
  • Add priority to alarms (1-3?)
  • Allow user to use GUI to select whether to run alarms for different priorities (e.g. you might want to have an alarm for engine failure but not for a burnt out bulb)

I really should be paying attention in class now, so I'll do it in about an hour

@602p
Copy link
Collaborator Author

602p commented Dec 10, 2014

Almost done: I want to

  • Add a button to shut the alarm up

,and then I'm done. What do you think about my additions? Can I get your feedback?

@Ippo343
Copy link
Owner

Ippo343 commented Dec 10, 2014

Hi Louis, it was 2 am here and now I am going to work. You will have my feedback this afternoon EST, I literally can't any earlier, sorry :/


Da: Louis Goesslingmailto:notifications@github.com
Inviato: ‎10/‎12/‎2014 02:10
A: Ippo343/DangItmailto:DangIt@noreply.github.com
Cc: Michelemailto:m.ippolito@outlook.com
Oggetto: Re: [DangIt] Alpha 5 (#80)

Almost done: Want to add a button to shut the alarm up, and then I'm done. What do you think about my additions? Can I get your feedback?


Reply to this email directly or view it on GitHub:
#80 (comment)

@602p
Copy link
Collaborator Author

602p commented Dec 10, 2014

No worries, that's fine. Additionally what do you thing about

  • Buffing jet engines (+intakes) to last for like ten hours

,because as it is, they fail very quickly if you are doing a spaceplanes flight with a long ascent.

@Ippo343
Copy link
Owner

Ippo343 commented Dec 10, 2014

Okay, everything looks great to me :)

Ippo343 added a commit that referenced this pull request Dec 10, 2014
@Ippo343 Ippo343 merged commit fa34205 into Ippo343:master Dec 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tank module is applied to batteries Air intakes clogging LOCA Failure Sound notifications
2 participants