Skip to content

Conversation

roninopf
Copy link
Contributor

🔹 Jira Ticket(s) if any

✏️ Description

  • adds authToken as a field that can be set when setting updating a user's email

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #447 (38d6cf4) into master (5a0abda) will decrease coverage by 0.04%.
The diff coverage is 21.73%.

❗ Current head 38d6cf4 differs from pull request most recent head 1fba386. Consider uploading reports for the commit 1fba386 to get more accurate results

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   62.47%   62.43%   -0.05%     
==========================================
  Files          66       66              
  Lines        3904     3913       +9     
  Branches      454      455       +1     
==========================================
+ Hits         2439     2443       +4     
- Misses       1227     1234       +7     
+ Partials      238      236       -2     
Impacted Files Coverage Δ
.../com/iterable/iterableapi/IterableAuthManager.java 17.64% <11.76%> (+2.02%) ⬆️
...ain/java/com/iterable/iterableapi/IterableApi.java 61.63% <50.00%> (-0.28%) ⬇️
...in/java/com/iterable/iterableapi/IterableUtil.java 67.28% <0.00%> (-2.81%) ⬇️
...com/iterable/iterableapi/IterableInAppManager.java 87.61% <0.00%> (+0.47%) ⬆️
.../iterable/iterableapi/IterableActivityMonitor.java 95.08% <0.00%> (+3.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@roninopf roninopf requested a review from Ayyanchira June 1, 2022 23:37
@davidtruong davidtruong self-requested a review June 9, 2022 17:50
@roninopf roninopf marked this pull request as draft July 20, 2022 18:27
@roninopf roninopf marked this pull request as ready for review July 28, 2022 21:04
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will have the success handler adjusted in the PR where its been worked upon.

@roninopf roninopf merged commit 651fa05 into master Aug 2, 2022
@roninopf roninopf deleted the jay/MOB-4439-update-email branch August 2, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants