Skip to content

[MOB-6425] align impression tracking signatures #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2023
Merged

[MOB-6425] align impression tracking signatures #590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed29205
updates impression tracking function signatures
Jun 23, 2023
d7cd7b9
updates function naming
Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions iterableapi/src/main/java/com/iterable/iterableapi/EmbeddedSessionManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,6 @@ public class EmbeddedSessionManager {
null
)
}

fun onMessageImpressionStarted(message: IterableEmbeddedMessage) {
IterableLogger.printInfo()
startImpression(message.metadata.messageId)
}

fun onMessageImpressionEnded(message: IterableEmbeddedMessage) {
IterableLogger.printInfo()
endImpression(message.metadata.messageId)
}

fun startImpression(messageId: String) {
var impressionData: EmbeddedImpressionData? = impressions[messageId]

Expand All @@ -83,7 +72,7 @@ public class EmbeddedSessionManager {
impressionData.start = Date()
}

fun endImpression(messageId: String) {
fun pauseImpression(messageId: String) {
val impressionData: EmbeddedImpressionData? = impressions[messageId]

if (impressionData == null) {
Expand Down