-
Notifications
You must be signed in to change notification settings - Fork 32
[MOB-6443] remove polling logic and adds callbacks to embedded session manager #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## embedded #591 +/- ##
=============================================
- Coverage 62.92% 40.65% -22.27%
=============================================
Files 68 72 +4
Lines 4070 4373 +303
Branches 469 491 +22
=============================================
- Hits 2561 1778 -783
- Misses 1257 2393 +1136
+ Partials 252 202 -50
☔ View full report in Codecov by Sentry. |
iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared some thoughts
iterableapi/src/main/java/com/iterable/iterableapi/EmbeddedSessionManager.kt
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/EmbeddedSessionManager.kt
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/EmbeddedSessionManager.kt
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt
Outdated
Show resolved
Hide resolved
0f05d3b
to
bbe9300
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🔹 Jira Ticket(s) if any
✏️ Description