Skip to content

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Jul 1, 2023

🔹 Jira Ticket(s) if any

✏️ Description

  • removes polling logic and fetching timer
  • makes syncMessages function public
  • adds onSwitchToForeground and onSwitchToBackground callbacks to the embedded session manager
  • removes setting auto fetching interval from config

@evantk91 evantk91 requested review from Ayyanchira and anlinguist July 1, 2023 17:58
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch coverage: 11.96% and project coverage change: -22.27 ⚠️

Comparison is base (f844696) 62.92% compared to head (7afb429) 40.65%.

❗ Current head 7afb429 differs from pull request most recent head 49b8e3e. Consider uploading reports for the commit 49b8e3e to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           embedded     #591       +/-   ##
=============================================
- Coverage     62.92%   40.65%   -22.27%     
=============================================
  Files            68       72        +4     
  Lines          4070     4373      +303     
  Branches        469      491       +22     
=============================================
- Hits           2561     1778      -783     
- Misses         1257     2393     +1136     
+ Partials        252      202       -50     
Impacted Files Coverage Δ
...com/iterable/iterableapi/EmbeddedImpressionData.kt 0.00% <0.00%> (ø)
...va/com/iterable/iterableapi/IterableConstants.java 0.00% <ø> (ø)
...om/iterable/iterableapi/IterableEmbeddedMessage.kt 0.00% <0.00%> (-79.20%) ⬇️
.../iterable/iterableapi/OfflineRequestProcessor.java 0.00% <0.00%> (-81.04%) ⬇️
...ain/java/com/iterable/iterableapi/IterableApi.java 34.14% <9.52%> (-27.23%) ⬇️
...om/iterable/iterableapi/IterableEmbeddedManager.kt 11.11% <11.11%> (ø)
...com/iterable/iterableapi/EmbeddedSessionManager.kt 12.69% <12.69%> (ø)
...va/com/iterable/iterableapi/IterableApiClient.java 39.40% <16.90%> (-36.66%) ⬇️
...om/iterable/iterableapi/IterableEmbeddedSession.kt 25.00% <25.00%> (ø)
...m/iterable/iterableapi/OnlineRequestProcessor.java 87.50% <100.00%> (+2.88%) ⬆️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evantk91 evantk91 changed the title [MOB-6443] remove polling logic [MOB-6443] remove polling logic and adds callbacks to embedded session manager Jul 5, 2023
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared some thoughts

Base automatically changed from evan/MOB-6425-align-impression-tracking-signatures to embedded July 12, 2023 15:37
@evantk91 evantk91 force-pushed the evan/MOB-6443-remove-polling-logic branch from 0f05d3b to bbe9300 Compare July 18, 2023 22:47
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evantk91 evantk91 merged commit c1042a3 into embedded Jul 18, 2023
@evantk91 evantk91 deleted the evan/MOB-6443-remove-polling-logic branch July 18, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants