-
Notifications
You must be signed in to change notification settings - Fork 32
[MOB-6490] toggle off impression tracking if no embedded messages #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOB-6490] toggle off impression tracking if no embedded messages #601
Conversation
iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments
iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## embedded #601 +/- ##
=============================================
- Coverage 62.92% 40.17% -22.75%
=============================================
Files 68 72 +4
Lines 4070 4398 +328
Branches 469 495 +26
=============================================
- Hits 2561 1767 -794
- Misses 1257 2427 +1170
+ Partials 252 204 -48
☔ View full report in Codecov by Sentry. |
🔹 Jira Ticket(s) if any
✏️ Description
This pull request includes the following: