Skip to content

[MOB-7749] card text container fix #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2024
Merged

[MOB-7749] card text container fix #699

merged 2 commits into from
Jan 29, 2024

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Jan 29, 2024 •
edited by atlassian bot
Loading

🔹 Jira Ticket(s) if any

✏️ Description

This pull request adds dimension value to card text container to resolve UI issue. Text container was not given a proper height to fit two lines of text for title and body.

@evantk91 evantk91 changed the base branch from master to embedded-clean-merge January 29, 2024 16:32
davidtruong
davidtruong approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@davidtruong davidtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@davidtruong davidtruong merged commit 786746d into embedded-clean-merge Jan 29, 2024
@davidtruong davidtruong deleted the evan/MOB-7749-card-text-container-fix branch January 29, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtruong davidtruong davidtruong approved these changes

@Ayyanchira Ayyanchira Awaiting requested review from Ayyanchira

@jyu115 jyu115 Awaiting requested review from jyu115

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evantk91 @davidtruong