Skip to content

Conversation

Ayyanchira
Copy link
Member

🔹 Jira Ticket(s) if any

✏️ Description

Fiterable app was throwing error as resource not found. Making the resource with full name is making it work. Probably would be helpful in all projects having such conflicts in finding the resource. Also bumping up the minSdkversion in api-ui

Fiterable app was throwing error as resource not found. Making the resource with full name is making it work. Probably would be helpful in all projects having such conflicts in finding the resource.
Also bumping up the minSdkversion in api-ui
Copy link
Contributor

@davidtruong davidtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required to also change the minsdk version number?

@davidtruong davidtruong self-requested a review January 29, 2024 21:26
Copy link
Contributor

@davidtruong davidtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d35abb1) 62.86% compared to head (2e16077) 62.82%.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           embedded-clean-merge     #700      +/-   ##
========================================================
- Coverage                 62.86%   62.82%   -0.05%     
========================================================
  Files                        75       75              
  Lines                      4678     4678              
  Branches                    529      529              
========================================================
- Hits                       2941     2939       -2     
- Misses                     1441     1442       +1     
- Partials                    296      297       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evantk91 evantk91 merged commit cbf0e96 into embedded-clean-merge Jan 29, 2024
@evantk91 evantk91 deleted the fully-qualified-style-name branch January 29, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants