Skip to content

Conversation

jyu115
Copy link
Contributor

@jyu115 jyu115 commented Sep 29, 2025

JIRA Ticket(s) if any

Description

  • setup playwright and configuration
  • built with POM (Page Object Model) approach. Page object files live under react-example/e2e/page-objects/pages/
  • added some basic playwright tests to help with Github Actions setup later

@jyu115 jyu115 requested a review from mprew97 as a code owner September 29, 2025 14:24
@jyu115 jyu115 requested a review from pauljung14 September 29, 2025 14:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.49%. Comparing base (1483ef5) to head (b53bcad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   74.49%   74.49%           
=======================================
  Files          57       57           
  Lines        2741     2741           
  Branches      820      820           
=======================================
  Hits         2042     2042           
  Misses        658      658           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@pauljung14 pauljung14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing lint error when running react-example app

[website] [webpack] ERROR in
[website] [webpack] /Users/paul.jung/dev/iterable-web-sdk/react-example/src/views/InApp.tsx
[website] [webpack]   48:24  error  Don't use `{}` as a type. `{}` actually means "any non-nullish value".
[website] [webpack] - If you want a type meaning "any object", you probably want `object` instead.
[website] [webpack] - If you want a type meaning "any value", you probably want `unknown` instead.
[website] [webpack] - If you want a type meaning "empty object", you probably want `Record<string, never>` instead.
[website] [webpack] - If you really want a type meaning "any non-nullish value", you probably want `NonNullable<unknown>` instead  @typescript-eslint/ban-types

which is not on main. Likely coming up because of changes with eslint rules (I see that @typescript-eslint package version is updated). We should resolve this error before merging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should rename this to UUATestingPage instead of "AUT..." to reduce confusion for future engineers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And other AUT -> UUA files

Copy link
Contributor

@mprew97 mprew97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a readme with instructions on how to run/test this within the /react-example/e2e directory? And then maybe adding a link to that from the base README?

Also will the github actions follow as a separate PR along with env var setup?

Copy link
Contributor

@mprew97 mprew97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add test cases for in-app functionality and base eventing as well? Or at least follow up with a later PR?

@jyu115
Copy link
Contributor Author

jyu115 commented Sep 29, 2025

Can we add a readme with instructions on how to run/test this within the /react-example/e2e directory? And then maybe adding a link to that from the base README?

Also will the github actions follow as a separate PR along with env var setup?

The github actions will follow as a separate PR with env var setup yes!

@jyu115
Copy link
Contributor Author

jyu115 commented Sep 29, 2025

Can we also add test cases for in-app functionality and base eventing as well? Or at least follow up with a later PR?

yes, I will expand tests for in-app, embedded messaging (and more in general) in a follow-up PR. I'll get the basic 2 specs in for now so we can get it ready for setting up Github Actions (make sure react sample app runs properly, tests run, test reporting is clear). once that's ready, I'll expand our tests to cover more features and test cases

- Resolved all conflicts by keeping main branch versions
- Updated dependencies to match main branch specifications
@jyu115 jyu115 merged commit 1ecf587 into main Sep 29, 2025
1 check passed
@jyu115 jyu115 deleted the MOB-12017-playwright-initial-setup branch September 29, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants