-
Notifications
You must be signed in to change notification settings - Fork 9
[MOB-12017] playwright initial setup #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
=======================================
Coverage 74.49% 74.49%
=======================================
Files 57 57
Lines 2741 2741
Branches 820 820
=======================================
Hits 2042 2042
Misses 658 658
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing lint error when running react-example app
[website] [webpack] ERROR in
[website] [webpack] /Users/paul.jung/dev/iterable-web-sdk/react-example/src/views/InApp.tsx
[website] [webpack] 48:24 error Don't use `{}` as a type. `{}` actually means "any non-nullish value".
[website] [webpack] - If you want a type meaning "any object", you probably want `object` instead.
[website] [webpack] - If you want a type meaning "any value", you probably want `unknown` instead.
[website] [webpack] - If you want a type meaning "empty object", you probably want `Record<string, never>` instead.
[website] [webpack] - If you really want a type meaning "any non-nullish value", you probably want `NonNullable<unknown>` instead @typescript-eslint/ban-types
which is not on main
. Likely coming up because of changes with eslint rules (I see that @typescript-eslint package version is updated). We should resolve this error before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should rename this to UUATestingPage instead of "AUT..." to reduce confusion for future engineers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And other AUT -> UUA files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a readme with instructions on how to run/test this within the /react-example/e2e
directory? And then maybe adding a link to that from the base README?
Also will the github actions follow as a separate PR along with env var setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add test cases for in-app functionality and base eventing as well? Or at least follow up with a later PR?
The github actions will follow as a separate PR with env var setup yes! |
yes, I will expand tests for in-app, embedded messaging (and more in general) in a follow-up PR. I'll get the basic 2 specs in for now so we can get it ready for setting up Github Actions (make sure react sample app runs properly, tests run, test reporting is clear). once that's ready, I'll expand our tests to cover more features and test cases |
- Resolved all conflicts by keeping main branch versions - Updated dependencies to match main branch specifications
JIRA Ticket(s) if any
Description
react-example/e2e/page-objects/pages/