Skip to content

fix some android studio warnings/recommendations #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021
Merged

fix some android studio warnings/recommendations #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions android/src/main/java/com/iterable/reactnative/Serialization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ static IterableInAppHandler.InAppResponse getInAppResponse(@Nullable Integer inA
static List<CommerceItem> commerceItemsFromReadableArray(ReadableArray array) {
ArrayList<CommerceItem> list = new ArrayList<>();
try {
JSONArray commerceItemJsonarray = convertArrayToJson(array);
for (int i = 0; i < commerceItemJsonarray.length(); i++) {
JSONObject item = commerceItemJsonarray.getJSONObject(i);
JSONArray commerceItemJsonArray = convertArrayToJson(array);
for (int i = 0; i < commerceItemJsonArray.length(); i++) {
JSONObject item = commerceItemJsonArray.getJSONObject(i);
list.add(commerceItemFromMap(item));
}
} catch (JSONException e) {
Expand Down Expand Up @@ -106,13 +106,13 @@ static JSONObject messageContentToJsonObject(IterableInAppMessage.Content conten
return messageContent;
}

static JSONArray serializeInAppMessages(List<IterableInAppMessage> inappMessages) {
JSONArray inappMessagesJson = new JSONArray();
for (IterableInAppMessage message : inappMessages) {
static JSONArray serializeInAppMessages(List<IterableInAppMessage> inAppMessages) {
JSONArray inAppMessagesJson = new JSONArray();
for (IterableInAppMessage message : inAppMessages) {
JSONObject messageJson = RNIterableInternal.getInAppMessageJson(message);
inappMessagesJson.put(messageJson);
inAppMessagesJson.put(messageJson);
}
return inappMessagesJson;
return inAppMessagesJson;
}

static IterableConfig.Builder getConfigFromReadableMap(ReadableMap iterableContextMap) {
Expand Down