[MOB-12039] rn-add-in-app-manager-back-onto-iterable-object #699
Conversation
|
|
Diff Coverage: The code coverage on the diff in this pull request is 100.0%. Total Coverage: This PR will increase coverage by 0.54%. File Coverage Changes
🛟 Help
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
| // THEN Iterable,inAppManager.getMessages returns the list of in-app messages | ||
| return await inAppManager.getMessages().then((messagesObtained) => { | ||
| // THEN Iterable.inAppManager.getMessages returns the list of in-app messages | ||
| return await Iterable.inAppManager?.getMessages().then((messagesObtained) => { |
There was a problem hiding this comment.
This approach feels right. Accessing it from Iterable global level.
| const inAppManager = new IterableInAppManager(); | ||
| // THEN Iterable,inAppManager.showMessage returns the simulated clicked url | ||
| return await inAppManager.showMessage(message, consume).then((url) => { | ||
| return await Iterable.inAppManager?.showMessage(message, consume).then((url) => { |
There was a problem hiding this comment.
Great to see inAppManager optional(?)
| const { IterableInAppManager } = require('../../inApp/classes/IterableInAppManager'); | ||
| this._inAppManager = new IterableInAppManager(); |
There was a problem hiding this comment.
Wow! This is insane! Never thought we could conditionally import!
There was a problem hiding this comment.
yeah. it's a little hacky, but it works in things like this.
lposen
deleted the
MOB-12039-rn-add-in-app-manager-back-onto-iterable-object
branch
🔹 JIRA Ticket(s) if any
✏️ Description
Added
inAppManagerback onto iterable object