Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isOk() in ParsedSlackReply is difficult to use #39

Closed
ja-ko opened this issue Dec 26, 2015 · 2 comments
Closed

isOk() in ParsedSlackReply is difficult to use #39

ja-ko opened this issue Dec 26, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@ja-ko
Copy link
Contributor

ja-ko commented Dec 26, 2015

Hi
I just updated to version 0.5
You decided to move the isOk() method from SlackReply to ParsedSlackReply. However no handle or Reply returned by SlackSession is related to ParsedSlackReply.
That means that whenever I want to check isOk() I need to cast my SlackReply to ParsedSlackReply and check isOk() then.
Did I miss something or is this the preferred approach?
If not, can you make isOk() easier to use?

@bcorne
Copy link
Contributor

bcorne commented Dec 26, 2015

Hi Drathi,

That's certainly a miss in they way I did some refactor. I keep the issue open and will fix that asap .

Best regards

Benoit

@bcorne bcorne self-assigned this Dec 26, 2015
bcorne added a commit that referenced this issue Mar 7, 2016
Now most of the replies from the slack API are implementing ParsedSlackReply
@bcorne
Copy link
Contributor

bcorne commented Mar 7, 2016

Ok, I've reworked the usage of ParsedSlackReply, this should be way easier to use now, please keep me informed if you still have some troubles with this.

Best regards,

Benoit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants