Fix for setting locale #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The locale is currently set by the value from the HTML tag's `lang` attribute. https://github.com/Itonomy/module-flowbox/blob/075ee836544f485e28e8743d3282c976202f4958/Block/Widget/Flow.php#L53 This includes the language, e.g. `en`, but not the region which makes it invalid for Flowbox. https://help.getflowbox.com/en/articles/4485750-changing-the-language-region-of-your-flow#our-supported-locales. The changes here fixes this to get the locale from the widget options, or if a locale is not set in the widget options, it will be gotten from the Magento store locale. https://docs.magento.com/user-guide/configuration/general/general.html#locale-options The reason for having an option in the widget, is that some Magento stores do not have their locale configured correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for the module, it works very nicely. I have a small improvement I'd like to share.
The Issue
The locale is currently set by the value from the HTML tag's
langattribute.module-flowbox/Block/Widget/Flow.php
Line 53 in 075ee83
This includes the language, e.g.
en, but not the region which makes it invalid for Flowbox.https://help.getflowbox.com/en/articles/4485750-changing-the-language-region-of-your-flow#our-supported-locales.
The Solution
The changes here fixes this to get the locale from the widget options, or if a locale is not set in the widget options, it will be gotten from the Magento store locale.
New Widget Option:
Magento store locale:
The reason for having an option in the widget, is that some Magento stores do not have their locale configured correctly.