Improve test benchmarks and update validation logic #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8475123560Details
💛 - Coveralls |
…enchmarks # Conflicts: # Makefile
An overhaul of the test benchmarks was conducted and various csv test files were generated. Also, updated the ValidationCsv logic in handling aggregation rules and optimizing validation conditions. Modifying the logic resulted in time and memory optimization for the CSV Validator.
The PHP setup block was removed from the GitHub Actions main workflow file as it is no longer needed. The creation of Docker images was enabled by uncommenting the respective code block. Furthermore, the command for running benchmarks was updated to use Docker instead of PHP directly. This modification will simplify the workflow and enhance its efficiency.
The PHP setup block was removed from the GitHub Actions main workflow file as it is no longer needed. The creation of Docker images was enabled by uncommenting the respective code block. Furthermore, the command for running benchmarks was updated to use Docker instead of PHP directly. This modification will simplify the workflow and enhance its efficiency.
The PHP setup block was removed from the GitHub Actions main workflow file as it is no longer needed. The creation of Docker images was enabled by uncommenting the respective code block. Furthermore, the command for running benchmarks was updated to use Docker instead of PHP directly. This modification will simplify the workflow and enhance its efficiency.
The PHP setup block was removed from the GitHub Actions main workflow file as it is no longer needed. The creation of Docker images was enabled by uncommenting the respective code block. Furthermore, the command for running benchmarks was updated to use Docker instead of PHP directly. This modification will simplify the workflow and enhance its efficiency.
Performance of CSV validation code was improved by modifying the debug option and marking the ComboInterquartileMean as a slow operation. Additionally, a benchmark test was renamed for consistency and the 'interquartile_mean' was disabled due to poor performance. The non-required 'benchmark-7-max-header.yml' file was deleted to clean up the code base.
Adjusted the CSV validation process for better performance by optimizing the debug option and marking ComboInterquartileMean as a slow operation. Renamed benchmark test for consistency, and disabled the 'interquartile_mean' due to performance issues. Removed the 'benchmark-7-max-header.yml' file which was not required, ultimately cleaning the codebase.
Adjusted the CSV validation process for better performance by optimizing the debug option and marking ComboInterquartileMean as a slow operation. Renamed benchmark test for consistency, and disabled the 'interquartile_mean' due to performance issues. Removed the 'benchmark-7-max-header.yml' file which was not required, ultimately cleaning the codebase.
Adjusted the CSV validation process for better performance by optimizing the debug option and marking ComboInterquartileMean as a slow operation. Renamed benchmark test for consistency, and disabled the 'interquartile_mean' due to performance issues. Removed the 'benchmark-7-max-header.yml' file which was not required, ultimately cleaning the codebase.
Renamed 'release-docker.yml' to 'publish.yml' and combined the functionality of 'release-phar.yml', which has now been deleted, into one unified GitHub Actions workflow. Also updated the debugging text in 'ComboCountZero.php' to improve readability and adjusted the badge's referenced file path in 'PackageTest.php'.
Renamed 'release-docker.yml' to 'publish.yml' and combined the functionality of 'release-phar.yml', which has now been deleted, into one unified GitHub Actions workflow. Also updated the debugging text in 'ComboCountZero.php' to improve readability and adjusted the badge's referenced file path in 'PackageTest.php'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An overhaul of the test benchmarks was conducted and various csv test files were generated. Also, updated the ValidationCsv logic in handling aggregation rules and optimizing validation conditions. Modifying the logic resulted in time and memory optimization for the CSV Validator.