Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp CSV validation process in GitHub workflow #15

Merged
merged 7 commits into from
Mar 13, 2024
Merged

Conversation

SmetDenis
Copy link
Member

No description provided.

Denis Smet added 2 commits March 13, 2024 03:38
This commit overhauls the CSV validation process in the GitHub workflow. The previous setup process was replaced with a new one focussed on validating CSV files using the 'jbzoo/csv-blueprint' library. Specifically, this involved checking for both valid and invalid CSV files and generating various reports based on the validation results. The commit also updates the README file with more detailed plans and ideas.
@coveralls
Copy link

coveralls commented Mar 12, 2024

Pull Request Test Coverage Report for Build 8260770563

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.382%

Totals Coverage Status
Change from base Build 8256758107: 0.0%
Covered Lines: 537
Relevant Lines: 563

💛 - Coveralls

Denis Smet added 5 commits March 13, 2024 03:44
Expanded upon the GitHub Actions workflow for Docker releases. Added steps to checkout, tag Docker images based on various attributes, and established QEMU and Docker Buildx. Also introduced a conditional login to Docker Hub, specifically to avoid logging in during pull requests.
Simplified the base images for Docker tags by removing redundancy. Switched from multi-line to single-line image specification. Previous tagging strategy dependent on various events/attributes is streamlined to only associate Docker tags based on branch, pull request and semantic versions. This simplifies the release process.
The wording in the README.md file's checklist has been simplified for clarity. The changes are particularly focused on the sections about batch processing, release workflow, and performance optimization. The new wording makes it easier to understand each item on the checklist, improving the documentation for developers and users.
The commit refactors the usage of actions/checkout in multiple parts of the demo.yml workflow, removing the redundant 'fetch-depth: 0' attribute for code simplification. Secondly, it resolves potential file path conflicts by updating the locations where CSV files are accessed in various steps, aiming at error prevention during runtime.
This commit removes "via GA" from the job name in demo.yml to keep it generic. Additionally, it widens the scope of trigger branches in release-docker.yml to include all ones with any types of names; previously, it was limited to branches with certain naming conventions only.
@SmetDenis SmetDenis merged commit 9da0d94 into master Mar 13, 2024
29 checks passed
@SmetDenis SmetDenis deleted the new-demo branch March 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants