Fix #90 - Diff mode Merged shows result only partially #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some background colors made did not match between the two versions. * Some foreground colors blended into the background color. * Color styles added for HTML Merged Renderer.
* Renderer doesn't show lines which where added to version 2 of a replaced block. Code assumed the same amount of lines in replacement blocks at both versions. Now it handles replacement block differently when the amount of lines are equal or differs. * Code cleanup. * ClassName for lines of replacement blocks are incorrect. Insertion is insinuated, but should be replacement.
Line headers of each equal or inserted line were given a class where it was supposed to be only the first line.
* Some values of title attributes had hardcoded references to one of the compared versions of text. They now refer to these versions using the titles as set in the renderers options. * Values can contain character sequences that break the HTML output of the renderer. The characters are now converted to HTML entities.
Code changes of the HTML merged renderer causes different output. The expected output for the phpunit test of this renderer is refactored to reflect those changes.
JBlond
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to fix #90 and also contains some other fixes of the HTML Merged renderer class which where found along the way.
It also closes #91 since the generated notice as described at that issue isn't related to php v.8.0, but to issue #90.