Improve Image identification in FitsImagePanel views

[bourgesl]

The FitsImagePanel displays a too complicated title (file name ...) from FitsImage.getFitsImageIdentifier()
It would be better to use the HDU_NAME (or renamed by the GUI) for the image, but also indicate the associated result.

Two solutions:

• modify FitsImagePanel to have a new ID field given with the image and displayed in place or as a prefix in the chart's title
• use setFitsImageIdentifier() to define the user-defined or better identifier in the OImaging code

To be investigated as the ViewerPanel only deals with FitsImageHDU so no mean to get its ServiceResult.

[buthanoid]

In IRModel.postProcessOIFitsFile ?
We could loop on FitsImages and call setFitsImageIdentifier. We would have both information about the service and the oifitsfile (we could totally add the service result as a parameter of postProcessOIFitsFile)
For the label, what about composing some interesting keywords like the algorithm used, the target, the hdu (primary or initial image), and the current count of images indexes ? And not printing the file name as currently, which is too long. example :
Id: PI_GRU-WISARD-PRIMARY-img(1/1)#3
The last #3 could be the index in the result table, for example.
After that we can still reflect about letting the user enter a completely personalized label.

[bourgesl]

What should be displayed for input images ? ie images loaded manually not coming from results.
If keywords change, like result ID, the image identifier should be updated as well...

[buthanoid]

Note : There is also different labels for images in the "Image Input list".
There is also image labels in the view panel, where you can choose which image you want to display (the input one (if any) or the result one).

[FerreolS]

Two case:

• OUTPUT image -> INDEX_HDUNAME
• FITS image -> FILENAME_HDUNAME

If no hduname use its number

[buthanoid]

• we need to check the behaviour of the images that are not added to the list because there already exist a check-sum-equal one, or the images that are renamed because the HDU name already exist in the list (the list I am talking about is IRModel.getFitsImageHDUs())
• HDU_NAME suggests updating the name when HDU_NAME updates, similar thing for INDEX

[buthanoid]

Problem:
when you click on "Run", it calls the function OIFitsWriter.writeOIFits, which himself call OIFitsWriter.createHDUnits. This last one creates HDUs from the ones found in IRModel.oifitsfile. Problem is that it calls FitsImageWriter.createImageData which always rename the image. Why ? At least in OImaging it does not serve because the file resulting from the algorithm will be loaded and its filename will be used for the image identifiers, so the filename of the input file will not appear in the result.
Also this renaming, while not appearing in the result of the run, actually change the name of the initial image used. This image can be the result of a previous run, which thus get renamed, which is confusing.
i propose to remove this renaming in FitsImageWriter, unless it is used for something

[buthanoid]

This reflect the weakness of just calling setFitsImageIdentifier once to modify the display. But I think it is an actual issue, not only impacting the development of the ticket here

[bourgesl]

As you described, the FitsImage identifier was aim to indicate 'filename ... 0/1..." so it is automatically updated by FitsImageLoader and FitsImageWriter to compute its value once.

I am a bit lost in your problem description as several Object instances are used in the workflow:

• input OIFits (in memory) - 1
• loaded Fits images (in memory) - 2
• saved OIFits (in /tmp), only used by UWS - 3
• loaded OIFits result (in /tmp) - 4

I think you should modify the FitsImage identifier once an image is loaded (in memory), so you just overwrite the value by what you want.
It should be done in IRModel loadImage(), loadOIFits (input) and addServiceResult().

I agree with you that 3 will modify the FitsImage identifier of images loaded (2), so it seems necessary to add a new runtime flag in oitools to discard automatic update in FitsImageWriter...

See https://github.com/JMMC-OpenDev/oitools/blob/master/src/main/java/fr/jmmc/oitools/model/DataModel.java that has few OITools flags.
You should add a new constant flag in FitsImageWriter to guard the following lines:

  236:  image.setFitsImageIdentifier(fileName + '#' + hduIndex);
  251:  image.setFitsImageIdentifier(fileName + '#' + hduIndex);

[buthanoid]

Yes what you described is what I meant, -3 modify -2.
I agree with the constant flag, it seems the safest since the writeOIFits functions is called in different situations : TestMergeUtils.merge, WriteOIFitsTest.writeLoadCompare, ViewerPanel.exportOIFits..
And the fitsImageIdentifier is also used in different situations.
We only know that in this specific situation it will be harmless to not update the identifier with the name of the temporary file

[buthanoid]

#34
JMMC-OpenDev/oitools#43

[buthanoid]

Not finished. I only renamed the images from the result for now.