Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to upload images to mapillary.com #54

Closed
FoliniC opened this issue Apr 25, 2017 · 17 comments
Closed

Unable to upload images to mapillary.com #54

FoliniC opened this issue Apr 25, 2017 · 17 comments
Assignees

Comments

@FoliniC
Copy link

FoliniC commented Apr 25, 2017

I didn't get how to upload images to mapillary from JOSM...
I tried importing images from file menu, selecting a bunch of images does nothing.

I also imported images and correlated with success. I didn't get how can I move them to the mapillary layer.
I'm on JOSM 11993 and mapillary 1.5.3

@floscher
Copy link
Member

floscher commented Apr 27, 2017

You'll need to select an image from the sequence you want to upload, then go to File › Upload images in the menu.
It's currently a bit confusing, I know… 😞

The changesets are when you want to change images that are already uploaded. But uploading these changesets is currently unavailable, because the API of @mapillary is not ready for that (see #27).

@floscher floscher changed the title Unable to add images to mapillary changeset Unable to upload images to mapillary.com Apr 27, 2017
@FoliniC
Copy link
Author

FoliniC commented Apr 27, 2017 via email

@drkludge
Copy link

drkludge commented Apr 27, 2017

@FoliniC I found that I have to create an OSM data layer as if I was going to add a node, way, or relation. Once the layer is there the JOSM Mapillary menu items are enabled.

Before new layer
image

After new layer. Naturally the other menu items will not be enabled until I import some images.
image

@FoliniC
Copy link
Author

FoliniC commented Apr 27, 2017 via email

@floscher floscher self-assigned this Apr 27, 2017
@drkludge
Copy link

drkludge commented Apr 28, 2017

@FoliniC

I also imported images and correlated with success. I didn't get how can I move them to the mapillary layer.
I'm on JOSM 11993 and mapillary 1.5.3

I think I understand now. You have to make a "round trip".

  1. Import images as a sequence. The upload menu item will be enable.

  2. Select at least one image. Now select the menu > File > Upload Pictures menu item to start the upload. You also have to respond to some dialog prompts before you can select the OK button.
    image

  3. Mapillary will process the data. (There is a time delay here.)

  4. Now go to back into JOSM once you receive the publication notice from Mapillary via email or application. I think that you have to enable these messages.

  5. Download some JOSM data where your images are.

  6. Then use JOSM menu > Imagery > Mapillary to create an image layer like Bing.
    image

image

In this case, I knew that there was a bus stop at the location and mapped it. I drove by the other day and performed the upload via the phone. Here we are talking about an upload via the JOSM plugin. Both have the same idea though. Tonight I can make sure that I positioned the flag in the correct location.

image

The difference here is that Bing will still download without OSM data present. The JOSM plugin will only download in the area where there is OSM data.

image

Also note that you can use the images in the layer before you upload the images to Mapilary. You don't have to "move the images to the Mapillary layer" to use them. The white nodes and line are for images that you have imported into a sequence. I have clicked on one of the white nodes in this case to show the image. The blue nodes and line are when you have selected a sequence after Mapillary has published the images. Likewise, the green nodes and lines are when you downloaded markers from Mapillary. The images are not shown until you click on the node. You will notice a pause while the JOSM plugin brings you that image.

@floscher
Copy link
Member

floscher commented Apr 28, 2017

I can't reproduce the problem (disabled menu entry "Upload images") using JOSM 11993 and Mapillary plugin v1.5.3, even when doing a "roundtrip".

@FoliniC Please make sure, that you see your images as light-grey dots with one of them selected (shown as red colored dot). Like it is shown in this screenshot:
Screenshot of enabled menu item

@FoliniC
Copy link
Author

FoliniC commented Apr 28, 2017 via email

@floscher
Copy link
Member

floscher commented Apr 28, 2017

@FoliniC Great, that it works now. Writing these up would really be helpful, if you have ideas for improvements. Especially I would be interested in how you tried it previously, that might help me to find out how we could have prevented this issue by better UI.

But you don't need to hurry, there already is plenty to do and work on here. It will take a while for me to find time to revise this, as long as there aren't more other developers turning up.
In this regard, thanks @drkludge for helping here to find the source of the problem, I really appreciated that.

@FoliniC
Copy link
Author

FoliniC commented Apr 29, 2017 via email

@floscher
Copy link
Member

floscher commented Apr 30, 2017 via email

@floscher
Copy link
Member

floscher commented May 1, 2017

@FoliniC I prepared a pre-release v1.5.4-beta, which can import images from a normal layer with geotagged images into the Mapillary layer. It also does no longer require to open an OSM data layer before opening the Mapillary layer.

Could you test it out by copying the file Mapillary.jar from https://github.com/JOSM/Mapillary/releases/tag/v1.5.4-beta and replace the file with the same name in the directory ~/.josm/plugins?

@FoliniC
Copy link
Author

FoliniC commented May 1, 2017 via email

@FoliniC
Copy link
Author

FoliniC commented May 1, 2017 via email

@floscher
Copy link
Member

floscher commented May 2, 2017

Thanks for testing 👍!
I'll send you a version where at least this exception should no longer happen.

@floscher
Copy link
Member

floscher commented May 7, 2017

Here's the improved beta-release for v1.5.4, which I promised. Hope this helps against that exception you got.

I'm sending it here instead of via mail, so that any other interested people can also test it out.

@FoliniC
Copy link
Author

FoliniC commented May 7, 2017 via email

@floscher
Copy link
Member

floscher commented May 7, 2017

Aaand the next iteration… v1.5.4-beta.3

This should fix the new issue, I used the wrong coordinates. Only those that were already written into the EXIF tags of the images, not the ones correlated from GPX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants