Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sets #1317

Merged
merged 7 commits into from
Aug 27, 2021
Merged

Update sets #1317

merged 7 commits into from
Aug 27, 2021

Conversation

manticore-projects
Copy link
Contributor

@manticore-projects manticore-projects commented Aug 27, 2021

Fixes #1313

Implement complex update sets:

CREATE TABLE test (
    a        VARCHAR (1)
    , b      VARCHAR (1)
    , c      VARCHAR (1)
)
;
-- queries were supported
update test
set (a, b) = (select '1', '2');

-- value lists were not supported <-- SOLVED
update test
set (a, b) = values( '1', '2');

-- simple expression lists were not supported <-- SOLVED
update test
set (a, b) = ('1', '2');

-- complex expression lists were not supported <-- SOLVED
update test
set (a, b) = (1, (select 2));

-- big boy updates were not supported <-- SOLVED
update test
set (a, b) = (select '1', '2')
      , c = '3'
;

@wumpz wumpz merged commit 21e5eba into JSQLParser:master Aug 27, 2021
@manticore-projects manticore-projects deleted the UpdateSets branch August 28, 2021 00:56
Copy link
Member

@wumpz wumpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged and could not build it. There were multiple pmd failures. After I solved those multiple checkstyle errors kicked in. Could it be, that the gradle build does not run pmd and checkstyle for each build?

@manticore-projects
Copy link
Contributor Author

manticore-projects commented Aug 29, 2021

Totally my bad and I would like to apologize. I rushed it and did not pay attention:

  1. PMD was active, but an additional filter for PRIORITY=1 was set (I have removed it)
  2. Checkstyle was not included, I have added that
  3. The GitHub CI quality assurance did not complain, but indicated success. It looks like only 2 out of the 3 usual test ran.

PR #1318 fixes these issues. I have verified that the Gradle build throws the same exceptions as the Maven build. Actually it spotted 2 more issues in the Test Sources based on using lastest CheckStyle Version. I have corrected these too.

Very sorry again about the sloppy work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants