Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displaced hover indicator in comboBox lists #5277

Closed
1 task done
calixtus opened this issue Sep 3, 2019 · 8 comments · Fixed by #5454
Closed
1 task done

Displaced hover indicator in comboBox lists #5277

calixtus opened this issue Sep 3, 2019 · 8 comments · Fixed by #5454
Labels
bug Confirmed bugs or reports that are very likely to be bugs ui
Milestone
v5.0

Comments

@calixtus
Copy link
Member

calixtus commented Sep 3, 2019 •
edited
Loading

JabRef 5.0-dev
Windows 10 10.0 amd64
Java 11.0.3-bellsoft

The ViewModelCellListFactory produces strange behaviour in combination with comboBoxes. In long lists the hover-indicator is displaced in relation to how far the list can be scrolled down.
Appears only with comboBoxes, other lists seem to work well.
Despite this bug, selection works.

Bug was mentioned in the PRs #5185 and #5265

Steps to reproduce the behavior:

  1. Open Fetcher SidePane
  2. Change Repository

combobox-cellfactory
@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs ui labels Sep 3, 2019
@calixtus calixtus mentioned this issue Sep 3, 2019
Merged
6 tasks
@AEgit
Copy link

AEgit commented Sep 8, 2019

JabRef 5.0-dev
Linux 5.0.0-27-generic amd64
Java 1.8.0_222

Cannot reproduce the behaviour mentioned above. I reckon this has now been fixed with #5265 (?).

@CyraxSector
Copy link
Contributor

I will start investigations on this

@AEgit
Copy link

AEgit commented Sep 12, 2019

JabRef 5.0-dev
Linux 5.0.0-27-generic amd64
Java 11.0.4

Ok, I can now reproduce this behaviour with the current snap version on the --edge channel. This indicates that this issue was introduced somewhere between the release of the current snap version (or rather the one from 9th September) on the --beta channel and the current snap version on the --edge channel.

@Siedlerchr
Copy link
Member

@CyraxSector You can try to narrow down the bug a git bisect:
https://git-scm.com/book/en/v2/Git-Tools-Debugging-with-Git

@calixtus calixtus mentioned this issue Sep 20, 2019
Closed
@CyraxSector
Copy link
Contributor

Cannot reproduce the behavior mentioned above. Can you please provide more information.

@tobiasdiez tobiasdiez added this to the v5.0 milestone Sep 27, 2019
@AEgit
Copy link

AEgit commented Sep 27, 2019

JabRef 5.0-dev--snapshot--2019-09-26--master--1a6c92c79
Windows 10 10.0 amd64
Java 11.0.4-bellsoft

I can still reproduce this behaviour. You can force it to happen by scrolling with the mouse wheel in the fetcher sidepane and then switching back to just scrolling with the mouse.
If you just scroll with the mouse (without using the mouse wheel) you will sometimes encounter the issue and sometimes not. But by using the mouse wheel scrolling first and then the mouse scrolling itself afterwards, the issue always appears.

tobiasdiez added a commit that referenced this issue Oct 16, 2019
@tobiasdiez
Fix highlight issues for lists
6fef097 
Fixes #5277 and fixes #5035. The problem was in both cases that the list view reuses nodes when scrolling (instead of creating new ones).
@tobiasdiez tobiasdiez mentioned this issue Oct 16, 2019
Merged
6 tasks
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@AEgit
Copy link

AEgit commented Oct 18, 2019

JabRef 5.0.0-dev--2019-10-18----bc26c3ac5
Windows 10 10.0 amd64
Java 12.0.2

I can confirm that this has been fixed in the current dev version.

Siedlerchr added a commit that referenced this issue Mar 14, 2021
@Siedlerchr
Squashed 'buildres/csl/csl-styles/' changes from 737ffa1..30fb68e
04cd0b7 
30fb68e Create BJEDIS-ABNT-Number (#5255)
aafb868 Update geochimica-et-cosmochimica-acta.csl (#5321)
60ba25f british-journal-of-anaesthesia.csl: add comma delimiter between non-sequential citations eg. 1 4 7-9 -> 1, 4, 7-9  (#5313)
67e6564 Reindent/reorder (#5318)
c0d2a39 Ruby 3.0.0 (#5309)
76d60ff Update harvard-anglia-ruskin-university.csl (#5310)
bc18ac9 Create journal-for-the-study-of-the-new-testament.csl (#5312)
aff602c Update journal-of-food-protection.csl (#5315)
4503826 Update muscle-and-nerve.csl (#5317)
3bed58e constant redefinition
4d718a0 update documentaiton link
fa99e2f add comma delimiter between succesive numbers
d396f8b Allow privileged testing of PRs (#5307)
43b22c7 Update masarykova-univerzita-pravnicka-fakulta.csl, pravnik.csl, iso690-full-note-cs.csl (#5308)
8a31c1e Update copernicus-publications.csl (#5303)
96760bb Update anabases.csl (#5304)
744de6d removed locale (#5300)
7eb0d60 Update aviation-space-and-environmental-medicine.csl (#5297)
2769970 Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5298)
51e3f4c Update harvard-university-of-bath.csl (#5299)
5fce84f Create cns-spectrums.csl (#5290)
bb8082c Create journal-of-surgical-oncology.csl (#5259)
90c13ae Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5288)
4bab1ad Update early-christianity.csl (#5289)
636ba78 Update tatup-zeitschrift-fur-technikfolgenabschatzung-in-theorie-und-… (#5291)
b7cc511 Create biotechnologia.csl (#5292)
5bab881 Update journal-of-orthopaedic-trauma.csl (#5287)
5943413 Fix locales (#5285)
302bd65 Update universite-du-quebec-a-montreal-departement-dhistoire.csl (#5286)
860ae48 Add Haaga-Helia University of Applied Sciences Harvard style (#5282)
c1c27de  Localize Metropolia style title (#5283)
508da89 Fix presentation for Methods of Information in Medicine (#5284)
53e1d0b Create geschichte-und-gesellschaft.csl (#5216)
d7ed0cb Create universite-de-geneve-departement-de-francais-moderne.csl (#5212)
80c404b Update journal-of-orthopaedic-trauma.csl (#5281)
20c143a Adding publishers' names (#5280)
6e5cd59 Update sodertorns-hogskola-oxford.csl (#5279)
52f2621 dollar-brace
a260294 Create journal-of-microbiology-and-biotechnology.csl (#5277)
1fc979e Create qeios.csl (#5261)
86347b7 GH does this for us -- again, sorry guys
b649589 Create experimental-biology-and-medicine.csl (#5276)
12ae0b1 Revert "tell sheldon about the job state"
bdcae89 tell sheldon about the job state
1240067 Add Vegetation classification and Survey (#5271)
6f398f0 Major update to Gallia.csl (#5269)
2a74b2c Update filters.yaml (#5273)
20046d2 Update spec_helper.rb (#5272)
2ee0dd8 Create the-sociological-review.csl (#5260)
5b8d09c move filters to inert file to pacify Sheldon (#5268)
e5f3315 Localize more language descriptors in style titles (#5270)
bfd2942 Localize more language descriptors in style titles (#5267)
35e276f Fix variable used for the label after indication of number of pages (#5240)
60f6371 Create Universidade-do-Estado-do-Rio-de-Janeiro.csl (#5247)
d8cc2ae Create the-journal-of-the-acoustical-society-of-america-numeric.csl (#5256)
92259c1 Create journal-of-financial-and-quantitative-analysis.csl (#5264)
6ba8aab Create journal-of-vestibular-research.csl (#5258)
0c88f41 Update european-journal-of-international-law.csl (#5265)
cff5abc Put language descriptor within parentheses
4a62709 Update monash-university-harvard.csl (#5253)
64fd1aa Localize more language descriptors in style titles (#5262)
f6519cb Localize more language descriptors in style titles (#5257)
170ccae tiny fixes for universitat-basel-iberoromanistik.csl (#5254)
b7284c9 Localize more language descriptors in style titles (#5252)
f4ef858 Add "Baishideng Publishing Group" dependents (#5251)
266e7c3 Make world-journal-of-hepatology.csl to bpg.csl parent (#5243)
9129098 fix small formatting issues for mclc.csl (#5229)
5d9560b Create crispr-journal.csl (#5249)
a217299 Change "Czech" to "Čeština" in titles (#5248)
4fef39a Create journal-of-open-research-software.csl (#5245)
2bff1a6 Change "Dutch" to "Nederlands" in titles (#5242)
f28da34 Update spec_helper.rb (#5246)
e0e977c Move content from wiki pages to markdown files (#5194)
018304c Update universite-de-montreal-apa.csl (#5239)
3b83e5c Create sodertorns-hogskola-oxford.csl (#5234)
1335378 Stop notifying 8827 port on Zotero servers (#5237)
f079b2a Update author-year disambiguation (#5238)
60bb0c9 Update technische-universitat-dresden-medizin.csl (#5236)
e374657 Create Leidraad voor juridische auteurs 2019 (Dutch) (#5223)
0450d89 Add new style for U of Mannheim, Germanistische Linguistik (#5228)
81f0689 Create health-sports-rehabilitation-medicine.csl (#5233)
c152a44 Update Gemfile.lock (#5235)
748e1eb Update geochimica-et-cosmochimica-acta.csl (#5231)
06b9ce8 Update zeitschrift-fur-theologie-und-philosophie.csl (#5230)
e747cb1 haute-ecole-de-gestion-de-geneve: Make polyglot & et al changes
4cfedb7 Create universite-de-sherbrooke-histoire.csl (#5210)
a96a61e Update journal-of-glaciology.csl (#5222)
c6a94c9 Add Journal of Human Rights (#5227)
c5c9c5f Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5214)
ffb7aa6 Create comparativ.csl (#5215)
e07329a Update lancaster-university-harvard.csl (#5220)
c075d41 Update mimesis-edizioni.csl (#5219)
502970a Removed space in year only citation (#5218)
13e8c6b Update acta-scientiae-veterinariae.csl (#5209)
0699da6 Remake mammallia.csl for Oct/2020 guidelines. (#5207)
b2dd3fd Update journal-of-international-business-studies.csl (#5217)
dd52bfe Update quaternaire.csl (#5199)
ccb1b0d rebuild webpage and article-journal citations in journal-of-forensic-sciences.csl (#5203)
f02f4fb Create pedosphere.csl (#5196)
70dd87a Create open-gender-journal.csl (#5198)
d272998 Create the-quarterly-journal-of-economics.csl (#5197)
d27cab3 fix locale issues, add cite-locator (#5206)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 30fb68e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs ui
Projects
Priorization
Archived in project
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Fix highlight issues for lists JabRef/jabref
5 participants
@Siedlerchr @CyraxSector @tobiasdiez @AEgit @calixtus