Conversion of Preferences / XMP and NameFormatters to mvvm #5265

calixtus · 2019-09-01T19:18:15Z

follow up to #5033
Quick and easy. Same issue with comboBox as in #5185, filed bug report in #5277

Should be ready to review,

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

calixtus · 2019-09-03T11:03:51Z

I'm going to have to resolve some merge-conflicts after merging #5185 .

tobiasdiez

As usual, a big thanks for your work! Again, as usual, the code looks really good. A few minor suggestions and then we can merge from my point of view.

(Will review your other PR as soon as possible, have a bit much to do at the moment. Sorry)

src/main/java/org/jabref/gui/actions/StandardActions.java

tobiasdiez · 2019-09-03T15:22:11Z

src/main/java/org/jabref/gui/preferences/NameFormatterTabView.java

+
+        formatterNameColumn.setSortable(true);
+        formatterNameColumn.setReorderable(false);
+        formatterNameColumn.setCellValueFactory(new PropertyValueFactory<>("name"));


Is there a reason not to use ValueTableCellFactory here (and below?)

Do you mean instead of PropertyValueFactory<>() or instead of TextFieldTableCell.forTableColumn()?

It's an editable cell I think?

I think it should look like

jabref/src/main/java/org/jabref/gui/openoffice/ManageCitationsDialogView.java

Lines 63 to 64 in 8520833

citation.setCellValueFactory(cellData -> cellData.getValue().citationProperty());

new ValueTableCellFactory<CitationEntryViewModel, String>().withGraphic(this::getText).install(citation);

or like

jabref/src/main/java/org/jabref/gui/openoffice/ManageCitationsDialogView.java

Lines 66 to 67 in 8520833

extraInfo.setCellValueFactory(cellData -> cellData.getValue().extraInformationProperty());

extraInfo.setEditable(true);

Well, I removed the PropertyValueFactory, but I think the ValueTableCellFactory does not support editable Cells.

src/main/java/org/jabref/gui/preferences/NameFormatterTabView.java

src/main/java/org/jabref/gui/preferences/NameFormatterTabViewModel.java

tobiasdiez · 2019-09-03T15:33:20Z

src/main/java/org/jabref/gui/preferences/XmpPrivacyTabView.java

+        fieldColumn.setSortable(true);
+        fieldColumn.setReorderable(false);
+        fieldColumn.setCellValueFactory(cellData -> cellData.getValue().fieldProperty());
+        fieldColumn.setCellFactory(cellData -> new TableCell<>() {


Here again, why not use the ValueTableCellFactory?

src/main/java/org/jabref/gui/preferences/XmpPrivacyTabView.java

src/main/java/org/jabref/gui/preferences/XmpPrivacyItemModel.java

src/main/java/org/jabref/gui/preferences/XmpPrivacyTabViewModel.java

calixtus · 2019-09-03T19:24:23Z

As usual, a big thanks for your work! Again, as usual, the code looks really good. A few minor suggestions and then we can merge from my point of view.

(Will review your other PR as soon as possible, have a bit much to do at the moment. Sorry)

As usual: There is no hurry! Really. Im just coding this in my not so free time to distract me from my real work with my thesis. This is just to have some fun and to remind me of the days I studied Informatik in 2004.

buhtz · 2019-09-04T08:43:24Z

Sorry for asking: But why do I receive e-mail notifications about this PR here? I am not subscribed to it.

Siedlerchr · 2019-09-04T08:51:49Z

@Codeberg-AsGithubAlternative-buhtz You may have accidentally subsribed or comemnted earlier on this pr? Or you are watching the repo. At the top right side next to an issue or PR you can unsubscribe.

30fb68e Create BJEDIS-ABNT-Number (#5255) aafb868 Update geochimica-et-cosmochimica-acta.csl (#5321) 60ba25f british-journal-of-anaesthesia.csl: add comma delimiter between non-sequential citations eg. 1 4 7-9 -> 1, 4, 7-9 (#5313) 67e6564 Reindent/reorder (#5318) c0d2a39 Ruby 3.0.0 (#5309) 76d60ff Update harvard-anglia-ruskin-university.csl (#5310) bc18ac9 Create journal-for-the-study-of-the-new-testament.csl (#5312) aff602c Update journal-of-food-protection.csl (#5315) 4503826 Update muscle-and-nerve.csl (#5317) 3bed58e constant redefinition 4d718a0 update documentaiton link fa99e2f add comma delimiter between succesive numbers d396f8b Allow privileged testing of PRs (#5307) 43b22c7 Update masarykova-univerzita-pravnicka-fakulta.csl, pravnik.csl, iso690-full-note-cs.csl (#5308) 8a31c1e Update copernicus-publications.csl (#5303) 96760bb Update anabases.csl (#5304) 744de6d removed locale (#5300) 7eb0d60 Update aviation-space-and-environmental-medicine.csl (#5297) 2769970 Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5298) 51e3f4c Update harvard-university-of-bath.csl (#5299) 5fce84f Create cns-spectrums.csl (#5290) bb8082c Create journal-of-surgical-oncology.csl (#5259) 90c13ae Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5288) 4bab1ad Update early-christianity.csl (#5289) 636ba78 Update tatup-zeitschrift-fur-technikfolgenabschatzung-in-theorie-und-… (#5291) b7cc511 Create biotechnologia.csl (#5292) 5bab881 Update journal-of-orthopaedic-trauma.csl (#5287) 5943413 Fix locales (#5285) 302bd65 Update universite-du-quebec-a-montreal-departement-dhistoire.csl (#5286) 860ae48 Add Haaga-Helia University of Applied Sciences Harvard style (#5282) c1c27de Localize Metropolia style title (#5283) 508da89 Fix presentation for Methods of Information in Medicine (#5284) 53e1d0b Create geschichte-und-gesellschaft.csl (#5216) d7ed0cb Create universite-de-geneve-departement-de-francais-moderne.csl (#5212) 80c404b Update journal-of-orthopaedic-trauma.csl (#5281) 20c143a Adding publishers' names (#5280) 6e5cd59 Update sodertorns-hogskola-oxford.csl (#5279) 52f2621 dollar-brace a260294 Create journal-of-microbiology-and-biotechnology.csl (#5277) 1fc979e Create qeios.csl (#5261) 86347b7 GH does this for us -- again, sorry guys b649589 Create experimental-biology-and-medicine.csl (#5276) 12ae0b1 Revert "tell sheldon about the job state" bdcae89 tell sheldon about the job state 1240067 Add Vegetation classification and Survey (#5271) 6f398f0 Major update to Gallia.csl (#5269) 2a74b2c Update filters.yaml (#5273) 20046d2 Update spec_helper.rb (#5272) 2ee0dd8 Create the-sociological-review.csl (#5260) 5b8d09c move filters to inert file to pacify Sheldon (#5268) e5f3315 Localize more language descriptors in style titles (#5270) bfd2942 Localize more language descriptors in style titles (#5267) 35e276f Fix variable used for the label after indication of number of pages (#5240) 60f6371 Create Universidade-do-Estado-do-Rio-de-Janeiro.csl (#5247) d8cc2ae Create the-journal-of-the-acoustical-society-of-america-numeric.csl (#5256) 92259c1 Create journal-of-financial-and-quantitative-analysis.csl (#5264) 6ba8aab Create journal-of-vestibular-research.csl (#5258) 0c88f41 Update european-journal-of-international-law.csl (#5265) cff5abc Put language descriptor within parentheses 4a62709 Update monash-university-harvard.csl (#5253) 64fd1aa Localize more language descriptors in style titles (#5262) f6519cb Localize more language descriptors in style titles (#5257) 170ccae tiny fixes for universitat-basel-iberoromanistik.csl (#5254) b7284c9 Localize more language descriptors in style titles (#5252) f4ef858 Add "Baishideng Publishing Group" dependents (#5251) 266e7c3 Make world-journal-of-hepatology.csl to bpg.csl parent (#5243) 9129098 fix small formatting issues for mclc.csl (#5229) 5d9560b Create crispr-journal.csl (#5249) a217299 Change "Czech" to "Čeština" in titles (#5248) 4fef39a Create journal-of-open-research-software.csl (#5245) 2bff1a6 Change "Dutch" to "Nederlands" in titles (#5242) f28da34 Update spec_helper.rb (#5246) e0e977c Move content from wiki pages to markdown files (#5194) 018304c Update universite-de-montreal-apa.csl (#5239) 3b83e5c Create sodertorns-hogskola-oxford.csl (#5234) 1335378 Stop notifying 8827 port on Zotero servers (#5237) f079b2a Update author-year disambiguation (#5238) 60bb0c9 Update technische-universitat-dresden-medizin.csl (#5236) e374657 Create Leidraad voor juridische auteurs 2019 (Dutch) (#5223) 0450d89 Add new style for U of Mannheim, Germanistische Linguistik (#5228) 81f0689 Create health-sports-rehabilitation-medicine.csl (#5233) c152a44 Update Gemfile.lock (#5235) 748e1eb Update geochimica-et-cosmochimica-acta.csl (#5231) 06b9ce8 Update zeitschrift-fur-theologie-und-philosophie.csl (#5230) e747cb1 haute-ecole-de-gestion-de-geneve: Make polyglot & et al changes 4cfedb7 Create universite-de-sherbrooke-histoire.csl (#5210) a96a61e Update journal-of-glaciology.csl (#5222) c6a94c9 Add Journal of Human Rights (#5227) c5c9c5f Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#5214) ffb7aa6 Create comparativ.csl (#5215) e07329a Update lancaster-university-harvard.csl (#5220) c075d41 Update mimesis-edizioni.csl (#5219) 502970a Removed space in year only citation (#5218) 13e8c6b Update acta-scientiae-veterinariae.csl (#5209) 0699da6 Remake mammallia.csl for Oct/2020 guidelines. (#5207) b2dd3fd Update journal-of-international-business-studies.csl (#5217) dd52bfe Update quaternaire.csl (#5199) ccb1b0d rebuild webpage and article-journal citations in journal-of-forensic-sciences.csl (#5203) f02f4fb Create pedosphere.csl (#5196) 70dd87a Create open-gender-journal.csl (#5198) d272998 Create the-quarterly-journal-of-economics.csl (#5197) d27cab3 fix locale issues, add cite-locator (#5206) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 30fb68e

Initial

b7c3d47

calixtus mentioned this pull request Sep 1, 2019

Convert PreferenceDialog to MVVM #5033

Merged

24 tasks

calixtus added 3 commits September 1, 2019 21:25

l10n

b49ce9d

Merge remote-tracking branch 'upstream/master' into preferences_xmp

fc0625a

Merge remote-tracking branch 'upstream/master' into preferences_xmp

c40d6b0

This was referenced Sep 3, 2019

Displaced hover indicator in comboBox lists #5277

Closed

Conversion of Preferences/TableColumnsTab to mvvm #5185

Merged

tobiasdiez requested changes Sep 3, 2019

View reviewed changes

calixtus added 3 commits September 3, 2019 17:59

Added validator and cleanups

ad2f0f3

Solved review issues

015ff51

l10n

19ac23a

Removed PropertyValueFactory

bce84e5

tobiasdiez merged commit cce5008 into JabRef:master Sep 4, 2019

calixtus deleted the preferences_xmp branch September 4, 2019 15:45

calixtus mentioned this pull request Sep 15, 2019

Conversion of preferences/exportsorting, import, maintable and entryeditor to mvvm #5315

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conversion of Preferences / XMP and NameFormatters to mvvm #5265

Conversion of Preferences / XMP and NameFormatters to mvvm #5265

calixtus commented Sep 1, 2019 •

edited

Loading

calixtus commented Sep 3, 2019

tobiasdiez left a comment

tobiasdiez Sep 3, 2019

calixtus Sep 3, 2019

Siedlerchr Sep 4, 2019

tobiasdiez Sep 4, 2019

calixtus Sep 4, 2019 •

edited

Loading

tobiasdiez Sep 3, 2019

calixtus commented Sep 3, 2019

buhtz commented Sep 4, 2019

Siedlerchr commented Sep 4, 2019

	citation.setCellValueFactory(cellData -> cellData.getValue().citationProperty());
	new ValueTableCellFactory<CitationEntryViewModel, String>().withGraphic(this::getText).install(citation);

	extraInfo.setCellValueFactory(cellData -> cellData.getValue().extraInformationProperty());
	extraInfo.setEditable(true);

Conversion of Preferences / XMP and NameFormatters to mvvm #5265

Conversion of Preferences / XMP and NameFormatters to mvvm #5265

Conversation

calixtus commented Sep 1, 2019 • edited Loading

calixtus commented Sep 3, 2019

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Sep 3, 2019

Choose a reason for hiding this comment

calixtus Sep 3, 2019

Choose a reason for hiding this comment

Siedlerchr Sep 4, 2019

Choose a reason for hiding this comment

tobiasdiez Sep 4, 2019

Choose a reason for hiding this comment

calixtus Sep 4, 2019 • edited Loading

Choose a reason for hiding this comment

tobiasdiez Sep 3, 2019

Choose a reason for hiding this comment

calixtus commented Sep 3, 2019

buhtz commented Sep 4, 2019

Siedlerchr commented Sep 4, 2019

calixtus commented Sep 1, 2019 •

edited

Loading

calixtus Sep 4, 2019 •

edited

Loading