Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bibtex citekey has non-ASCII letters #6583

Closed
1 task done
houshuang opened this issue Jun 4, 2020 · 11 comments · Fixed by #6938
Closed
1 task done

Bibtex citekey has non-ASCII letters #6583

houshuang opened this issue Jun 4, 2020 · 11 comments · Fixed by #6938

Comments

@houshuang
Copy link

JabRef version 5.0, MacOS 10.14.16

I added a citation, and autogenerated a cite key, it contains a non-ASCII letter.

According to a 7-year old issue:

The key generator handles accented and other non-ASCII characters by replacement with ASCII characters deemed equivalent. If you have issues where this is not working properly, we'd be happy to look into it.
https://sourceforge.net/p/jabref/bugs/155/

image

@InProceedings{bakki2018modèle,
  author = {Aïcha Bakki},
  date   = {2018},
  title  = {Modèle et outil pour soutenir la scénarisation pédagogique de MOOC connectivistes},
  file   = {:/Users/stian/Downloads/Thèse_BAKKI_AICHA_Version_F.pdf:PDF},
  year   = {2018},
}
@AEgit
Copy link

AEgit commented Jun 4, 2020

Just a quick question: Have you actually tested the issue using the current dev version? You have ticked the field, but the version you report above (5.0) does not represent the current latest development version (see https://builds.jabref.org/master/).

If you have not used the latest development version, always remember to make a backup of your JabRef database, before installing the dev version.

If you have used the latest dev version, you can ignore this post.

@houshuang
Copy link
Author

houshuang commented Jun 4, 2020 via email

@AEgit
Copy link

AEgit commented Jun 4, 2020

I reckon, the behaviour in the latest dev version is the same, isn't it?

@houshuang
Copy link
Author

houshuang commented Jun 4, 2020 via email

@AEgit
Copy link

AEgit commented Jun 4, 2020

Cheers, ok, so this is something that needs to be fixed then.

@Siedlerchr
Copy link
Member

Hmm. Maybe the Characters are not in the unwanted chars list in the preferences

@tobiasdiez
Copy link
Member

Maybe the simplest solution would be to create new formatter that converts everything to ASCII (and maybe activate it by default).

public static List<Formatter> getConverters() {
return Arrays.asList(
new HtmlToLatexFormatter(),
new HtmlToUnicodeFormatter(),
new LatexToUnicodeFormatter(),
new UnicodeToLatexFormatter()
);
}

@Siedlerchr
Copy link
Member

Didn't we recently had the change to the illegal and unwanted characters? @koppor

@tobiasdiez
Copy link
Member

Yes we have, but I don't think unicode characters are illegal (at least not for biblatex). Moreover, illegal characters would be simply removed, but here we would like to replace them by their asci equivalent.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Sep 3, 2020

'è' and 'é' are legal characters but they should be replaced by 'e' (because of bibtex).

Normalizing with NFC fixes the issue for me.

I agree with @tobiasdiez that there should be a formatter, as it would allow users to remove Unicode from file/dir names if they want to (since it will be included by default among modifiers, so [title:UnicodeTo...] is valid). It can be done by wrapping StringUtils#replaceSpecialCharacters.

Should I take a look at it?

@Siedlerchr
Copy link
Member

Thanks to @k3KAW8Pnf7mkmdSMPHz27 this should be fixed now in the latest development version.

The new version is currently building and approx ready in half an hour

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

koppor pushed a commit that referenced this issue Jul 15, 2023
a97dbb32c5 Update studii-teologice.csl (#6591)
e19e08780e Update acm-sig-proceedings-long-author-list.csl (#6594)
c8abbcdd88 Update acm-sig-proceedings.csl (#6595)
725ace4a40 Create uppsala-university-library-harvard.csl (#6574)
a973041e0e update bluebook-law-review.csl (#6583)
0891cfc49a Update masarykova-univerzita-pravnicka-fakulta.csl (#6589)
80b3861bce Update al-jamiah-journal-of-islamic-studies.csl (#6581)
b6fb00e415 Create arachnologische-mitteilungen.csl (#6375)
2dbc8edf8e Update universitat-basel-iberoromanistik.csl (#6580)
fd230a7073 Create veterinary-clinical-pathology.csl (#6372)
ac0afa3cae Create dedicated Basque APA file (#6370)
fee0677a88 Update chicago-author-date.csl (#6289)
ca1bf2db6e Create van-yuzuncu-yil-universitesi-fen-bilimleri-enstitusu.csl (#6230)
f4116db325 Create Turcica.csl (#6240)
0e4311a802 Create jurnal-teknik-mesin-indonesia.csl (#6211)
e73bf46674 Update vancouver.csl (#6156)
b73c3ef193 Create independent TF AIP Style
befa82e7ef Create harvard-xi-an-jiaotong-liverpool-univeisity.csl (#6181)
048c9bddbc Add csl for SDMI (#6129)
1c2aedd088 Update and rename dependent/energy-research-and-social-science.csl to energy-research-and-social-science.csl (#6567)
b77084255f Update the-quarterly-journal-of-economics.csl (#6572)
cf66f60f25 Update publicatiewijzer-voor-de-archeologie.csl (#6577)
9e9e08c219 Update isara-iso-690.csl (#6578)
4b4e8f442d Create silva-fennica.csl (#6568)
dd8760bb2b Update american-journal-of-botany.csl (#6569)
8b0e505363 Update haute-ecole-de-gestion-de-geneve-iso-690.csl (#6560)
016050c4b7 Update geographie-et-cultures.csl (#6563)
e8b62f1c80 Update and rename dependent/retina.csl to retina.csl (#6565)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: a97dbb32c57c8c00e47422dae4ba4f480e753da5
koppor pushed a commit that referenced this issue Aug 1, 2023
0749a19b83 Update journal-of-experimental-botany.csl (#6604)
b1768724fe Update modern-language-association.csl (#6606)
dd364c1815 Create modern-language-association-for-JEI.csl (#6593)
6cb436997b Partial update of APA styles for 1.0.2, including software, legal, most localizations (#6270)
d7c4ebec85 fix film/video authors for american-sociological-association.csl (#6602)
a97dbb32c5 Update studii-teologice.csl (#6591)
e19e08780e Update acm-sig-proceedings-long-author-list.csl (#6594)
c8abbcdd88 Update acm-sig-proceedings.csl (#6595)
725ace4a40 Create uppsala-university-library-harvard.csl (#6574)
a973041e0e update bluebook-law-review.csl (#6583)
0891cfc49a Update masarykova-univerzita-pravnicka-fakulta.csl (#6589)
80b3861bce Update al-jamiah-journal-of-islamic-studies.csl (#6581)
b6fb00e415 Create arachnologische-mitteilungen.csl (#6375)
2dbc8edf8e Update universitat-basel-iberoromanistik.csl (#6580)
fd230a7073 Create veterinary-clinical-pathology.csl (#6372)
ac0afa3cae Create dedicated Basque APA file (#6370)
fee0677a88 Update chicago-author-date.csl (#6289)
ca1bf2db6e Create van-yuzuncu-yil-universitesi-fen-bilimleri-enstitusu.csl (#6230)
f4116db325 Create Turcica.csl (#6240)
0e4311a802 Create jurnal-teknik-mesin-indonesia.csl (#6211)
e73bf46674 Update vancouver.csl (#6156)
b73c3ef193 Create independent TF AIP Style
befa82e7ef Create harvard-xi-an-jiaotong-liverpool-univeisity.csl (#6181)
048c9bddbc Add csl for SDMI (#6129)
1c2aedd088 Update and rename dependent/energy-research-and-social-science.csl to energy-research-and-social-science.csl (#6567)
b77084255f Update the-quarterly-journal-of-economics.csl (#6572)
cf66f60f25 Update publicatiewijzer-voor-de-archeologie.csl (#6577)
9e9e08c219 Update isara-iso-690.csl (#6578)
4b4e8f442d Create silva-fennica.csl (#6568)
dd8760bb2b Update american-journal-of-botany.csl (#6569)
8b0e505363 Update haute-ecole-de-gestion-de-geneve-iso-690.csl (#6560)
016050c4b7 Update geographie-et-cultures.csl (#6563)
e8b62f1c80 Update and rename dependent/retina.csl to retina.csl (#6565)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 0749a19b8306f2e8dcb9bf1a2e3a6992666030ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants