-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Split relativizeSymlinks parameterized tests in separate tests #13782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion and OpenSelectedEntriesFilesAction - Introduced OpenSingleExternalFileAction to handle single entry with one linked file - Introduced OpenSelectedEntriesFilesAction to handle multiple selection cases Fixes JabRef#13431
…13505) Bumps [org.junit.platform:junit-platform-launcher](https://github.com/junit-team/junit-framework) from 1.13.1 to 1.13.3. - [Release notes](https://github.com/junit-team/junit-framework/releases) - [Commits](https://github.com/junit-team/junit-framework/commits) --- updated-dependencies: - dependency-name: org.junit.platform:junit-platform-launcher dependency-version: 1.13.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
…resolution - Use real/canonical paths to ensure files are correctly recognized as within a directory, even through symlinks - Add and document unit tests covering symlinked and normal directory scenarios fixes JabRef#12995
…Path and remove unnecessary comments
…bref into fix-for-issue-12995
… simplicity, and ensured all edge cases from issue JabRef#12995 are now covered.
…bref into fix-for-issue-12995
…bref into fix-for-issue-12995
@trag-bot didn't find any issues in the code! ✅✨ |
Please clean up the git history. |
I think, its OK this time - diff is right. Next time @Muskan244 please base on latest |
Got it, thanks! I’ll rebase on the latest main in future PRs. |
No need for rebase: git fetch upstream git checkout upstream/main git checkout -b newbranch (There are surely more easy steps, but this is what I do) |
Thanks for clarifying, I’ll use this approach from next time. |
* upstream/main: (54 commits) Split relativizeSymlinks parameterized tests in separate tests (#13782) Update the search syntax highlight for web search (#13801) Chore(deps): Bump ai.djl:bom from 0.33.0 to 0.34.0 in /versions (#13833) Fix typos in CHANGELOG.md (#13826) Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#13831) Chore(deps): Bump org.gradlex:extra-java-module-info in /build-logic (#13830) Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (#13832) Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#13834) Chore(deps): Bump jablib/src/main/resources/csl-locales (#13829) Chore(deps): Bump jablib/src/main/resources/csl-styles (#13827) Chore(deps): Bump jablib/src/main/abbrv.jabref.org (#13828) add: CAYW endpoint formats (#13785) New Crowdin updates (#13823) chore(deps): update dependency org.kohsuke:github-api to v2.0-rc.5 (#13822) Add support for automatic ICORE conference ranking lookup [#13476] (#13699) New Crowdin updates (#13820) Initialize search bar auto-completion with real database context (no tab switch needed) (#13816) Fixes #13274: Allow cygwin-paths on Windows (#13297) Refine "REDACTED" replacement of API key value in web fetcher search URL (#13814) changed ISSNCleanup into NormalizeIssn, refactored respective tests #13748 (#13767) ...
Follow-up to PR #13553 based on review by @koppor.
This PR improves the readability of the code by splitting relativizeSymlinks() parameterized test cases into separate test cases.
Steps to test
Gradle: ./gradlew test
Ensure all tests in FileUtilTest related to symlink handling pass without errors.
Mandatory checks
CHANGELOG.md
in a way that is understandable for the average user (if change is visible to the user)