Skip to content

Conversation

Muskan244
Copy link
Contributor

Follow-up to PR #13553 based on review by @koppor.

This PR improves the readability of the code by splitting relativizeSymlinks() parameterized test cases into separate test cases.

Steps to test

  • Build JabRef and run the full test suite:
    Gradle: ./gradlew test
    Ensure all tests in FileUtilTest related to symlink handling pass without errors.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Muskan244 and others added 30 commits July 8, 2025 13:23
…ion and OpenSelectedEntriesFilesAction

- Introduced OpenSingleExternalFileAction to handle single entry with one linked file
- Introduced OpenSelectedEntriesFilesAction to handle multiple selection cases

Fixes JabRef#13431
…13505)

Bumps [org.junit.platform:junit-platform-launcher](https://github.com/junit-team/junit-framework) from 1.13.1 to 1.13.3.
- [Release notes](https://github.com/junit-team/junit-framework/releases)
- [Commits](https://github.com/junit-team/junit-framework/commits)

---
updated-dependencies:
- dependency-name: org.junit.platform:junit-platform-launcher
  dependency-version: 1.13.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
…resolution

- Use real/canonical paths to ensure files are correctly recognized as within a directory, even through symlinks
- Add and document unit tests covering symlinked and normal directory scenarios
fixes JabRef#12995
… simplicity, and ensured all edge cases from issue JabRef#12995 are now covered.
@Muskan244 Muskan244 changed the title Follow up for pr 13553 Split relativizeSymlinks parameterized tests in separate tests Aug 28, 2025
Copy link

trag-bot bot commented Aug 28, 2025

@trag-bot didn't find any issues in the code! ✅✨

@subhramit
Copy link
Member

subhramit commented Aug 29, 2025

Please clean up the git history.
It has commits unrelated to the changes and by other authors.

@koppor
Copy link
Member

koppor commented Aug 29, 2025

Please clean up the git history.
It has commits unrelated to the changes and by other authors.

I think, its OK this time - diff is right.

Next time @Muskan244 please base on latest main.

@Muskan244
Copy link
Contributor Author

Got it, thanks! I’ll rebase on the latest main in future PRs.

@koppor
Copy link
Member

koppor commented Aug 29, 2025

Got it, thanks! I’ll rebase on the latest main in future PRs.

No need for rebase:

git fetch upstream

git checkout upstream/main

git checkout -b newbranch

(There are surely more easy steps, but this is what I do)

@Muskan244
Copy link
Contributor Author

Thanks for clarifying, I’ll use this approach from next time.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 8, 2025
Merged via the queue into JabRef:main with commit e75937b Sep 8, 2025
2 checks passed
Siedlerchr added a commit that referenced this pull request Sep 8, 2025
* upstream/main: (54 commits)
  Split relativizeSymlinks parameterized tests in separate tests (#13782)
  Update the search syntax highlight for web search (#13801)
  Chore(deps): Bump ai.djl:bom from 0.33.0 to 0.34.0 in /versions (#13833)
  Fix typos in CHANGELOG.md (#13826)
  Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#13831)
  Chore(deps): Bump org.gradlex:extra-java-module-info in /build-logic (#13830)
  Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (#13832)
  Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#13834)
  Chore(deps): Bump jablib/src/main/resources/csl-locales (#13829)
  Chore(deps): Bump jablib/src/main/resources/csl-styles (#13827)
  Chore(deps): Bump jablib/src/main/abbrv.jabref.org (#13828)
  add: CAYW endpoint formats (#13785)
  New Crowdin updates (#13823)
  chore(deps): update dependency org.kohsuke:github-api to v2.0-rc.5 (#13822)
  Add support for automatic ICORE conference ranking lookup [#13476] (#13699)
  New Crowdin updates (#13820)
  Initialize search bar auto-completion with real database context (no tab switch needed) (#13816)
  Fixes #13274: Allow cygwin-paths on Windows (#13297)
  Refine "REDACTED" replacement of API key value in web fetcher search URL (#13814)
  changed ISSNCleanup into NormalizeIssn, refactored respective tests #13748 (#13767)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants