Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate GVK plugin #378

Merged
merged 13 commits into from
Nov 25, 2015
Merged

Integrate GVK plugin #378

merged 13 commits into from
Nov 25, 2015

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 21, 2015

This integrates the GVK plugin into JabRef.

Location of the original source code at http://jabref.tempelb.de/

@koppor koppor mentioned this pull request Nov 21, 2015
Closed
13 tasks
@koppor
GVKFetcher: Ensure that first letter of subtitle is always capitalized
7047a1d 
Minor improvements:
 * replace calls to datafield.getAttribute("tag") by a single variable
@koppor koppor mentioned this pull request Nov 22, 2015
Merged
@koppor koppor added this to the v3.0 milestone Nov 23, 2015
@koppor
Copy link
Member Author

koppor commented Nov 23, 2015

@JabRef/developers Please checkout this branch and run GVKParserTest locally. I updated from jdk1.8.0_51 to jdk1.8.0_66 and all tests fail here. The field ordering changed. The fields are not sorted as provided at https://github.com/JabRef/jabref/blob/gvk_fetcher/src/test/resources/net/sf/jabref/importer/fetcher/gvk_result_for_797485368.bib. Does this relate to koppor#34 somehow?

@koppor koppor mentioned this pull request Nov 23, 2015
Merged
4 tasks
@koppor
Introduce canonical BibTeX format and create BibtexEntryAssert
51c0c1a 
 * adapt GVKParserTest accordingly
 * use Guava Strings.isNullOrEmpty in hasCiteKey and getFieldOrAlias
 * fix UTF-8 encoding in test cases
@koppor
Merge branch 'master' into gvk_fetcher
b8dcb5b 
# Conflicts:
#	src/main/java/net/sf/jabref/model/entry/BibtexEntry.java
@koppor
Change label of GVK Fetcher
bee6637 
We use the German description instead of "GVK (Common Union Catalogue)" as GVK is typically used in Germany and (currently) the help file states the English translation.
@koppor
Move BibtexEntry.toString() to CanonicalBibtexEntry.getCanonicalRepre…
a1430d7 
…sentation(e)
@koppor
Honor biblatex mode at default constructor
1776bb6
@simonharrer
Copy link
Contributor

Looks good to me.

koppor added a commit that referenced this pull request Nov 25, 2015
@koppor
Merge pull request #378 from JabRef/gvk_fetcher
5f3ee69 
Integrate GVK plugin
@koppor koppor merged commit 5f3ee69 into master Nov 25, 2015
@koppor koppor deleted the gvk_fetcher branch November 25, 2015 17:58
@hauschke
Copy link

hauschke commented Dec 2, 2015

GVK search doesn't work for me, using JabRef 3.0 on Windows 7. After starting a search I get no response. The progress bar goes on and on and on until I hit "cancel". Other searches (DOAJ, DBLP, IEEE) work. The used search terms work in GVK itself, too.

@matthiasgeiger
Copy link
Member

Works fine for me...

What are the search terms you have used?
Are there any messages in the error console (Help -> Show Error Console)?

@hauschke
Copy link

hauschke commented Dec 2, 2015

Search term examples: "marketing", "Papula,Lothar", "Papula, Lothar", "wlan", "mtbf"

Output of Error Console:

Exception in thread "JabRef CachedThreadPool" java.lang.NullPointerException: Every BibtexEntry must have a type.
at java.util.Objects.requireNonNull(Unknown Source)
at net.sf.jabref.model.entry.BibtexEntry.setType(BibtexEntry.java:125)
at net.sf.jabref.model.entry.BibtexEntry.(BibtexEntry.java:76)
at net.sf.jabref.importer.fetcher.GVKParser.parseEntry(GVKParser.java:367)
at net.sf.jabref.importer.fetcher.GVKParser.parseEntries(GVKParser.java:63)
at net.sf.jabref.importer.fetcher.GVKParser.parseEntries(GVKParser.java:40)
at net.sf.jabref.importer.fetcher.GVKFetcher.fetchGVK(GVKFetcher.java:170)
at net.sf.jabref.importer.fetcher.GVKFetcher.processQuery(GVKFetcher.java:111)
at net.sf.jabref.importer.fetcher.GeneralFetcher$4.run(GeneralFetcher.java:288)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

@stefan-kolb stefan-kolb self-assigned this Dec 2, 2015
@stefan-kolb
Copy link
Member

Reproducible. Is caused by unknown entry types inside the fetcher.

@stefan-kolb stefan-kolb removed their assignment Dec 2, 2015
@stefan-kolb
Copy link
Member

Please continue discussion in #447.

@koppor
Copy link
Member Author

koppor commented Dec 2, 2015

@hauschke Workaround: Switch to BibLaTeX mode

@koppor koppor mentioned this pull request Sep 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: documentation type: enhancement
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@koppor @simonharrer @hauschke @matthiasgeiger @stefan-kolb @jfmaas