-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyOpenSci Initial Review Cleanup #144
Comments
Additional Comments:(see here for full explanations) ReferencesMany references in the README are paywalled, try and find open-access versions. Some references are also missing, include them. Also make sure that the Formatting FixesExternal links with backquotes are breaking in the Sphinx rendered documentation. DocumentationAdd further examples of some of the backend, and how users could leverage other functionality implemented in Version AttributeSpecify a [project]
name = "astartes"
dynamic = ["version"]
[tool.setuptools.dynamic]
version = {attr = "package.__version__"} Which is compatible with both |
All of this is done in #147 except for fixing the references and some documentation for the internal functions. |
Resolves #144 - addressing comments and feedback from the initial pyOpenSci editor review.
Feedback from Initial Submission to pyOpenSci
In the meanwhile I have a first question for you, if you don't mind.
While the statistical side of the package is clear and answers to a well known need of the scikit-learn user community, I would like to read a bit more about the package connections with chemical engineering. I guess your scientific application was the motivation for this development in the first place and in the documentation the two aspects look quite unrelated. Perhaps a small pedagogical section about chemical applications in the documentation will also be helpful? Thanks!
Originally posted by @cmarmo in pyOpenSci/software-submission#120 (comment)
We need to clarify the applications of
astartes
to chemical engineering in particular rather than just the importance in terms of statistics and ML, broadly speaking. As mentioned by @kspieks offline there is some content in the JOSS paper that could be pulled from to flesh this out.I would suggest that we make a separate markdown document, like the 'sklearn to astartes' one and reference it in the main README.
The text was updated successfully, but these errors were encountered: