Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyOpenSci Initial Review Comments Fixup #147

Merged
merged 12 commits into from Jul 17, 2023
Merged

Conversation

JacksonBurns
Copy link
Owner

Resolves #144 - addressing comments and feedback from the initial pyOpenSci editor review.

@JacksonBurns JacksonBurns self-assigned this Jul 16, 2023
@JacksonBurns JacksonBurns added the PR Ready for Review Mark a PR as Ready for Review for the GitHub coverage checker bot label Jul 16, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage meets or exceeds 90% threshold (currently 98%).

@JacksonBurns JacksonBurns marked this pull request as ready for review July 16, 2023 17:48
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage meets or exceeds 90% threshold (currently 98%).

@kspieks kspieks merged commit 98db8fe into main Jul 17, 2023
24 checks passed
@JacksonBurns JacksonBurns deleted the pyopensci_initial_review_fixups branch July 17, 2023 14:19
JacksonBurns added a commit that referenced this pull request Jul 21, 2023
no longer needed since demos were move to google collab (#147)
@JacksonBurns JacksonBurns mentioned this pull request Jul 21, 2023
kspieks added a commit that referenced this pull request Jul 21, 2023
no longer needed since demos were move to google collab (#147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Ready for Review Mark a PR as Ready for Review for the GitHub coverage checker bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyOpenSci Initial Review Cleanup
2 participants