Guard against xhr.getAllResponseHeaders() being null
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -267,13 +267,16 @@ | |||
|
|
|||
| function headers(xhr) { | |||
| var head = new Headers() | |||
| var pairs = xhr.getAllResponseHeaders().trim().split('\n') | |||
There was a problem hiding this comment.
var pairs = (xhr.getAllResponseHeaders() || '').trim().split('\n')
There was a problem hiding this comment.
I agree that this approach would be more elegant than wrapping everything in a typeof check.
There was a problem hiding this comment.
Sure. I was just trying to avoid creating and forEach-ing that array for nothing.
|
@steveluscher This looks great. Can you squash this into a single commit? If you accept the contributor license agreement by clicking the |
|
cc/ @jamesgpearce |
From https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest#getAllResponseHeaders(): > Returns all the response headers, separated by CRLF, as a string, or null if no response has been received. I discovered this on Android, once when `xhr.getAllResponseHeaders()` evaluated to `null`.
|
Thanks, @steveluscher! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest#getAllResponseHeaders():
I discovered this on Android, once when
xhr.getAllResponseHeaders()evaluated tonull.