Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata for repository, bugs and license #67

Merged
merged 2 commits into from
Jan 22, 2015
Merged

Add metadata for repository, bugs and license #67

merged 2 commits into from
Jan 22, 2015

Conversation

danez
Copy link
Contributor

@danez danez commented Jan 14, 2015

This would be nice as this information is displayed in the npm repository.

@domenic
Copy link

domenic commented Jan 14, 2015

bugs is redundant with repository and repository can just be "repository": "github/fetch"

@danez
Copy link
Contributor Author

danez commented Jan 14, 2015

Oh I haven't checked that in detail, will do it later.

@danez
Copy link
Contributor Author

danez commented Jan 22, 2015

@domenic I couldn't find any reference on what you said, all examples state, you should us a full url to your repository. And bugs is a different url that is used by git bugs

And the markup was copied from an official package, so it should be quite correct.

@domenic
Copy link

domenic commented Jan 22, 2015

It's correct, but it's way longer than it needs to be, and a maintenance burden.

Here's another official package or three you can copy markup from:

@domenic
Copy link

domenic commented Jan 22, 2015

@danez
Copy link
Contributor Author

danez commented Jan 22, 2015

Seems this shorter way of defining the guthub repository is not covered in the official docs about package.json.
Now its changed.

josh added a commit that referenced this pull request Jan 22, 2015
Add metadata for repository, bugs and license
@josh josh merged commit 9a1ef9d into JakeChampion:master Jan 22, 2015
@josh
Copy link
Contributor

josh commented Jan 22, 2015

cools

@danez danez deleted the patch-1 branch January 22, 2015 20:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants