Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing the app #102

Merged
merged 8 commits into from
Jan 19, 2021
Merged

Polishing the app #102

merged 8 commits into from
Jan 19, 2021

Conversation

JakuJ
Copy link
Owner

@JakuJ JakuJ commented Jan 16, 2021

Quite a few small changes in this PR:

  • bugfix: now it's the right-click that opens menus in the Composer. This fixes the drag-and-click bug.
  • docs: Some missing documentation in the Help modal was added (Ctrl+S in the editor, menus in the Composer).
  • optimization: response compression has been enabled (Brotli), achieving some nice speedups when it comes to page load time
  • optimization: most CSS files load asynchronously
  • feature: the menu for adding gates manually has been improved and features 12 intrinsics now

Closes #100
Part of #90

Zrzut ekranu 2021-01-19 o 20 06 16

@JakuJ JakuJ added bug Something isn't working documentation Improvements or additions to documentation labels Jan 16, 2021
@JakuJ JakuJ self-assigned this Jan 16, 2021
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #102 (95f7e72) into develop (60e4e33) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #102      +/-   ##
===========================================
+ Coverage    95.89%   95.93%   +0.03%     
===========================================
  Files           50       51       +1     
  Lines         1268     1278      +10     
===========================================
+ Hits          1216     1226      +10     
  Misses          52       52              
Flag Coverage Δ
unittests 95.93% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Explorer/Components/Composer/Cell.razor 100.00% <ø> (ø)
Explorer/Components/Composer/Grids.razor 100.00% <ø> (ø)
Explorer/Components/Modals/HelpModal.razor 100.00% <ø> (ø)
Explorer/Pages/_Host.cshtml 0.00% <ø> (ø)
Explorer/Components/Composer/AddGateMenu.razor 100.00% <100.00%> (ø)
.../Components/Composer/Drawing/GateMeasurement.razor 100.00% <100.00%> (ø)
Explorer/Components/Composer/Gate.razor 100.00% <100.00%> (ø)
Explorer/Components/Composer/Grid.razor 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e4e33...95f7e72. Read the comment docs.

@JakuJ JakuJ changed the title Open Composer menus with right-click Polishing the app Jan 19, 2021
Copy link
Collaborator

@skdw skdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app gets loaded so fast now!
Interacting with the Composer has also became much more pleasant 🎉

@skdw skdw merged commit 139a194 into develop Jan 19, 2021
@skdw skdw deleted the feature/qol branch January 19, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add info about CTRL+S to the help modal
2 participants