Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchonize 2.0 with master #93

Merged
merged 97 commits into from
Jan 19, 2017
Merged

Synchonize 2.0 with master #93

merged 97 commits into from
Jan 19, 2017

Conversation

StudioMaX
Copy link
Collaborator

I seen that someone already created a version 2.0 with support of the namespaces and PSR-4 compliance, but this version not updated since March 2015 and looks like dead at this time.
But this version still could be useful with the modern php frameworks like Symfony.
So, I have updated this version with the last commits from master branch from 2017-01-19.

JamesHeinrich and others added 30 commits May 30, 2015 19:46
Please accept this PR.
http://www.getid3.org/phpBB3/viewtopic.php?t=1892
Missing getid3_lib include
Increase length of database fields
JamesHeinrich#51
Attempt to detect non-standard ID3v1 encodings (e.g. Windows-1251)
JamesHeinrich#53
Workaround for taggers that put multiple genres into a single genre
field as semicolon-separated string.
JamesHeinrich#54
Ignore time_scale values of >=1000 to attempt to set correct video frame
rate while ignoring global and audio time_scale values
$filename to $localtempfilename  in remote file analysis section
…e-patch-1

fixes readme.md variable reference
copy change from JamesHeinrich#55 from
readme.md to readme.txt
function CombineMultipleMP3sTo() in demos/demo.joinmp3.php can now be
used to extact audio samples from one or more input files.
Browsers unsupported MIME type "audio/x-wave"
fix typo: comparing instead of assign
Fixed inconsistency in relation to module.tag.id3v2.php
Fixed .gitignore comments so the package can be cached by satis for composer install.
JamesHeinrich and others added 23 commits July 28, 2016 08:30
Added a lot of missing ones and updated wrong names, now consistent with list in module.tag.id3v2.php.
This makes reading and writing of id3v2 compatible with each other.
To easier see the changes made in
JamesHeinrich#84
Update write.id3v2.php available frames
Restore consistent column alignment after merging
JamesHeinrich@df1faa0
…ding

Increase composer autoloading classmap definitions
…ting

Can't specify value for the 'GRID' tag
Change all warnings that used direct access to
$this->getid3->info['warning'][] to use $this->warning() instead
Change all errors that used direct access to
$this->getid3->info['error'][] to use $this->error() instead
Bitrate calculation is incomplete and may be wrong. Help is appreciated
if you know how to calculate bitrate for E-AC3 correctly.
# Conflicts:
#	.gitignore
#	README.md
#	composer.json
#	demos/demo.basic.php
#	demos/demo.browse.php
#	demos/demo.cache.mysql.php
#	demos/demo.joinmp3.php
#	getid3/module.audio-video.matroska.php
#	src/GetID3.php
#	src/Module/Archive/Gzip.php
#	src/Module/Archive/Rar.php
#	src/Module/Archive/Szip.php
#	src/Module/Archive/Zip.php
#	src/Module/Audio/Aa.php
#	src/Module/Audio/Aac.php
#	src/Module/Audio/Ac3.php
#	src/Module/Audio/Amr.php
#	src/Module/Audio/Au.php
#	src/Module/Audio/Avr.php
#	src/Module/Audio/Bonk.php
#	src/Module/Audio/Dss.php
#	src/Module/Audio/La.php
#	src/Module/Audio/Midi.php
#	src/Module/Audio/Monkey.php
#	src/Module/Audio/Mp3.php
#	src/Module/Audio/Mpc.php
#	src/Module/Audio/OptimFrog.php
#	src/Module/Audio/Rkau.php
#	src/Module/Audio/Shorten.php
#	src/Module/Audio/Tta.php
#	src/Module/Audio/Voc.php
#	src/Module/Audio/Vqf.php
#	src/Module/Audio/WavPack.php
#	src/Module/AudioVideo/Asf.php
#	src/Module/AudioVideo/Bink.php
#	src/Module/AudioVideo/Flv.php
#	src/Module/AudioVideo/Nsv.php
#	src/Module/AudioVideo/QuickTime.php
#	src/Module/AudioVideo/Swf.php
#	src/Module/AudioVideo/Ts.php
#	src/Module/Graphic/Bmp.php
#	src/Module/Graphic/Efax.php
#	src/Module/Graphic/Gif.php
#	src/Module/Graphic/Jpg.php
#	src/Module/Graphic/Png.php
#	src/Module/Misc/Exe.php
#	src/Module/Misc/MsOffice.php
#	src/Module/Tag/ApeTag.php
#	src/Module/Tag/ID3v1.php
#	src/Module/Tag/ID3v2.php
#	src/Module/Tag/Lyrics3.php
#	src/Utils.php
#	src/Write/ApeTag.php
#	src/Write/ID3v1.php
#	src/Write/ID3v2.php
#	src/Write/Lyrics3.php
#	src/Write/MetaFlac.php
#	src/Write/Real.php
#	src/Write/VorbisComment.php
#	src/WriteTags.php
@JamesHeinrich JamesHeinrich merged commit cc24da5 into JamesHeinrich:2.0 Jan 19, 2017
@JamesHeinrich
Copy link
Owner

Great, thank you.
I'm not working on 2.0, but I have merged your changes in case anyone else is interested in doing so.

@Gemorroj
Copy link
Contributor

@JamesHeinrich, it is your big mistake that you don't want to develop a new and improved version.
Sorry if this sounds rude.

@StudioMaX StudioMaX mentioned this pull request Mar 14, 2018
Copy link

@Budda0ne Budda0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link

@Budda0ne Budda0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try[```

@StudioMaX StudioMaX added the 2.x Issues related to GetID3 2.x label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues related to GetID3 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.