Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Casts in Generated Code and Add FAWMN #283

Closed
JasonBock opened this issue Nov 26, 2023 · 1 comment
Closed

Remove Casts in Generated Code and Add FAWMN #283

JasonBock opened this issue Nov 26, 2023 · 1 comment
Labels
enhancement Medium Priority
Milestone
8.0.0

Comments

@JasonBock
Copy link
Owner

Describe the solution you'd like
My notes are here. The first thing I need to do is see if this approach would perform better before I start modifying the generation. If that helps, then I'll make the full investment.

Describe alternatives you've considered
Leave things as-is.
@JasonBock JasonBock added this to the 7.4.0 milestone Nov 26, 2023
@JasonBock JasonBock changed the title Remove Casts in Generated Code Remove Casts in Generated Code and Add FAWMN Dec 2, 2023
@JasonBock
Copy link
Owner Author

I've done some perf work, and it looks like it's viable. I'm also going to change to FAWMN, which will also be a breaking change, but should be the right thing overall. Should also doc that developers should put all RockCreate<> or RockMake<> attributes in one file, and try to not duplicate any definitions. I could potentially create a diagnostic to warn developers when they do that, but that's minor.

JasonBock added a commit that referenced this issue Dec 21, 2023
@JasonBock
#283 the first step: RockAttribute
ab29340
JasonBock added a commit that referenced this issue Dec 23, 2023
@JasonBock
#283 starting to make progress on building handlers and properties fo…
3dfb74e 
…r expectations
JasonBock added a commit that referenced this issue Dec 24, 2023
@JasonBock
#283 more generator progress with methods and properties, also cleani…
1be1ab9 
…ng up gen'd code
JasonBock added a commit that referenced this issue Dec 24, 2023
@JasonBock
#283 more create progress, constructors, new V4 classes
0295ebd
JasonBock added a commit that referenced this issue Dec 26, 2023
@JasonBock
#283 yet more progress on mocking methods
713d762
JasonBock added a commit that referenced this issue Dec 26, 2023
@JasonBock
#283 initial property work done
0428663
JasonBock added a commit that referenced this issue Dec 26, 2023
@JasonBock
#283 initial indexer stuff is done.
8240119
JasonBock added a commit that referenced this issue Dec 26, 2023
@JasonBock
#283 started working on expectation classes, methods first
89ba871
JasonBock added a commit that referenced this issue Dec 26, 2023
@JasonBock
#283 more method expectation work, moving to properties and indexers
9ec37ad
JasonBock added a commit that referenced this issue Dec 27, 2023
@JasonBock
#283 more property/indexer expectation setup work
2d66f4a
JasonBock added a commit that referenced this issue Dec 27, 2023
@JasonBock
#283 yay! First successful compilation of V4 no-cast approact
fddc8f4
JasonBock added a commit that referenced this issue Dec 27, 2023
@JasonBock
#283 added some clean-up notes
829e403
JasonBock added a commit that referenced this issue Dec 28, 2023
@JasonBock
#283 shortened up the callback + return value work
072895b
JasonBock added a commit that referenced this issue Dec 28, 2023
@JasonBock
#283 getting more gen code cleaned up
f0f3a38
JasonBock added a commit that referenced this issue Dec 28, 2023
@JasonBock
#283 decided not to gen event extension methods, let the user create …
11e3270 
…a RaiseEventInofrmation.
JasonBock added a commit that referenced this issue Dec 28, 2023
@JasonBock
#283 fixed a bug with properties and list handler generation, did a q…
28d0d72 
…uick perf test, first one is looking good :)
JasonBock added a commit that referenced this issue Dec 28, 2023
@JasonBock
#283 changed expectation field to property in mock type
2b7c7a3
JasonBock added a commit that referenced this issue Dec 29, 2023
@JasonBock
#283 worked on the make build type, things initially looking good
b11f888
JasonBock added a commit that referenced this issue Dec 29, 2023
@JasonBock
#283 added a thrown exception that I somehow deleted
d47f16c
JasonBock added a commit that referenced this issue Dec 29, 2023
@JasonBock
#283 updated more tests, now running into open generic fun
b79c7ef
JasonBock added a commit that referenced this issue Dec 29, 2023
@JasonBock
#283 made progress with generic methods
b2cc472
JasonBock added a commit that referenced this issue Dec 29, 2023
@JasonBock
#283 working and fixing constraints
ab5013d
JasonBock added a commit that referenced this issue Dec 29, 2023
@JasonBock
#283 updating constructor and default value tests
407f894
JasonBock added a commit that referenced this issue Dec 30, 2023
@JasonBock
#283 working on explicit properties and indexers
5a0600e
JasonBock added a commit that referenced this issue Dec 30, 2023
@JasonBock
#283 more test updates
231a206
JasonBock added a commit that referenced this issue Jan 1, 2024
@JasonBock
#283 all tests converted (I think), need to fix pointer, ref struct, …
7d9cd77 
…and some reformatting issues
JasonBock added a commit that referenced this issue Jan 2, 2024
@JasonBock
#283 fixed a bunch of stuff with property gen and visibility
ef5ed5a
JasonBock added a commit that referenced this issue Jan 4, 2024
@JasonBock
#283 lots of fixes with member expectation types needing to hide base…
f5f9078 
… definitions
JasonBock added a commit that referenced this issue Jan 5, 2024
@JasonBock
#283 lots of work getting esoteric types to work, still some cases to…
c3916c1 
… cover, but very close now
JasonBock added a commit that referenced this issue Jan 6, 2024
@JasonBock
#283 more work with special types, just need to get indexer tests to …
8a67051 
…pass now.
JasonBock added a commit that referenced this issue Jan 6, 2024
@JasonBock
#283 more work on indexers
bc8e28e
JasonBock added a commit that referenced this issue Jan 6, 2024
@JasonBock
#283 YAY! All tests pass :)
704d341
JasonBock added a commit that referenced this issue Jan 6, 2024
@JasonBock
#283 first run of the code gen app, found some bugs, but may be able …
3b27bb8 
…to optimize more....
JasonBock added a commit that referenced this issue Jan 7, 2024
@JasonBock
#283 lot more changes on esoteric type generation, reduced code gen e…
de30560 
…rror count, still gotta fix some more things...
JasonBock added a commit that referenced this issue Jan 8, 2024
@JasonBock
#283 more fixes, down to 7 code gen errors
6a1b400
JasonBock added a commit that referenced this issue Jan 8, 2024
@JasonBock
#283 YAY! All tests + code gen tests pass
85df16e
JasonBock added a commit that referenced this issue Jan 9, 2024
@JasonBock
#283 keep going over pointers and ref structs, but...will this work?
d0e82e9
JasonBock added a commit that referenced this issue Jan 9, 2024
@JasonBock
#283 starting to change integration tests
e1b7759
JasonBock added a commit that referenced this issue Jan 10, 2024
@JasonBock
#283 more integration test updates
3778990
JasonBock added a commit that referenced this issue Jan 10, 2024
@JasonBock
#283 integration tests (sans repository) are updated
4d31e40
JasonBock added a commit that referenced this issue Jan 10, 2024
@JasonBock
#283 MAJOR step, all tests pass, things are looking good (still need …
abf7f63 
…to do some refinements)
JasonBock added a commit that referenced this issue Jan 11, 2024
@JasonBock
#283 removed non-V4 code
0b1072c
JasonBock added a commit that referenced this issue Jan 11, 2024
@JasonBock
#283 udpated tests to use a shared set of references
8a10114
JasonBock added a commit that referenced this issue Jan 11, 2024
@JasonBock
#283 usings are finally gone
4fd74a4
JasonBock added a commit that referenced this issue Jan 11, 2024
@JasonBock
#283 renaming types in gen'd code to remove mock type name, 20 tests …
ad5264c 
…still failing
JasonBock added a commit that referenced this issue Jan 11, 2024
@JasonBock
#283 more renames!
52533ac
JasonBock added a commit that referenced this issue Jan 11, 2024
@JasonBock
#283 shim rename is in
884b847
JasonBock added a commit that referenced this issue Jan 12, 2024
@JasonBock
#283 event extensions work, need to do some adornments adjustments
89014a8
JasonBock added a commit that referenced this issue Jan 12, 2024
@JasonBock
#283 finally got event extensions working
030c62f
JasonBock added a commit that referenced this issue Jan 12, 2024
@JasonBock
#283 Updated NuGet packages
78fb7ba
JasonBock added a commit that referenced this issue Jan 12, 2024
@JasonBock
#283 added Coravel
a220165
JasonBock added a commit that referenced this issue Jan 13, 2024
@JasonBock
#283 making some minor refactorings and code cleanups
0bd7a12
JasonBock added a commit that referenced this issue Jan 13, 2024
@JasonBock
#283 updating documentation (will need review)
70deee8
JasonBock added a commit that referenced this issue Jan 13, 2024
@JasonBock
#283 final commit for this feature! merge time
e350e8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Medium Priority
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@JasonBock