New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal calling not working for 3.3.1-websocket #54

Open
xenithorb opened this Issue Nov 21, 2015 · 21 comments

Comments

Projects
None yet
@xenithorb
Copy link

xenithorb commented Nov 21, 2015

Using "LibreSignal" from eutopia.cz/experimental/fdroid/repo
Version: 3.3.1-websocket

Calling does not work between websocket and GCM, I have not tested websocket <--> websocket, gcm <--> gcm works.

On the GCM end, the call continues to ring until failure.
On the websocket end, the call starts and then immediately fails.

Any idea if this will ever work?

@JavaJens

This comment has been minimized.

Copy link
Owner

JavaJens commented Nov 21, 2015

I have never used this, so I don't really know.
But from what others have reported, calling works fine, but receiving does not. See the comments in here: #39

However, I think the registration is still disabled.

@JavaJens

This comment has been minimized.

Copy link
Owner

JavaJens commented Nov 21, 2015

@f41c0r I think we can enable the registration to Redphone. What do you say?
From a quick test this allows calling people, but, of course, being called doesn't work.
The caller that tries to call a websocket phone gets a message "Not registered user" or similar.

@relyt29

This comment has been minimized.

Copy link

relyt29 commented Nov 21, 2015

I'm fine with it, as long as its clear to everyone that its buggy, maybe add a note in the readme about it and add it to the popup code you just merged?

@h-2

This comment has been minimized.

Copy link

h-2 commented Nov 29, 2015

being called doesn't work.

Is this a problem of upstream, i.e. is there no websocket API for the phone-stuff? Or is it a problem in the forked client?

If I can help through testing, please let me know!

Thanks!

@JavaJens

This comment has been minimized.

Copy link
Owner

JavaJens commented Nov 29, 2015

@h-2 Well, sorta. The source code for the (unified) server is not available. I think they are running two separate servers in parallel, so the phone stuff is handled by the original RedPhone server for which there never was open source.

I asked on the mailinglist regarding websocket support for calls, but never got a reply.
I might open a ticket against the server source, but am not sure yet on how to make it an issue and not a discussion 😉

@h-2

This comment has been minimized.

Copy link

h-2 commented Nov 29, 2015

so the phone stuff is handled by the original RedPhone server for which there never was open source.

really? 😟

Do you know if they ever planned on releasing it?

I might open a ticket against the server source, but am not sure yet on how to make it an issue and not a discussion 😉

Yeah, I understand. Thanks for not giving up 👍

@relyt29

This comment has been minimized.

Copy link

relyt29 commented Nov 29, 2015

Do we have any documentation whatsoever on the redphone protocol? Is there a chance its just vanilla XMPP + ZRTP like jitsi can do?

I saw your post on the mailing list javajens, I hope they decide to release source... :S

@xmikos

This comment has been minimized.

Copy link

xmikos commented Nov 30, 2015

@f41c0r It's standard ZRTP, but they use their own simple signaling protocol, not XMPP or SIP. But with key continuity check disabled after switch from RedPhone to Signal, there is much greater chance of MITM then in other ZRTP-based phone apps :-(

@ThomasWaldmann

This comment has been minimized.

Copy link

ThomasWaldmann commented Dec 7, 2015

Can confirm that with the self-compiled code from websocket-reborn branch, getting voice called (likely from normal signal) and voice calling (likely to normal signal) does not work. The first times out after a while, the latter says "Login failed" immediately.

+1 for documenting known-working and known-not-working stuff.

@anoadragon453

This comment has been minimized.

Copy link

anoadragon453 commented Dec 15, 2015

Also getting an immediate "Login Failed" upon WebSocket --> GCM.

@sarevok-anchev

This comment has been minimized.

Copy link

sarevok-anchev commented Jan 4, 2016

Still an issue with 3.8.1-websocket for me (and I presume, everyone else).

Anyone working on getting this fixed?

When calling --> "LOGIN FAILED!" almost immediately.
Others calling --> says my number is not registered for secure voice.

@mimi89999

This comment has been minimized.

Copy link

mimi89999 commented Jan 4, 2016

@sarevok-anchev First somebody has to convince moxie0 to open-source the RedPhone server...

@sarevok-anchev

This comment has been minimized.

Copy link

sarevok-anchev commented Jan 5, 2016

@mimi89999: Could you clarify? RedPhone/Signal are open source, couldn't whatever magic they're doing be replicated in LibreSignal?

What exactly is failing here?

And how to best move forward?

@mimi89999

This comment has been minimized.

Copy link

mimi89999 commented Jan 5, 2016

RedPhone/Signal are open source, couldn't whatever magic they're doing be replicated in LibreSignal?

They use GCM (Google Cloud Messaging).
If you don't have gapps installed on your phone, you can't use GCM...
(and probably you don't want to install gapps :-) )

Look at: #54 (comment)

@sarevok-anchev

This comment has been minimized.

Copy link

sarevok-anchev commented Jan 6, 2016

I see. Indeed, I don't want to install gapps :)

So, essentially, we'd need to get moxie0 onboard with the effort in order to have working calls from/to LibreSignal?

@aphirst

This comment has been minimized.

Copy link

aphirst commented Jan 8, 2016

I can confirm that the normal (not -websockets) builds of LibreSignal work with calls if you use microG on your (rooted, and if it isn't OmniROM or built yourself with relevant signature-spoofing patches, with an xposed module) GApps-free Android device. @mimi89999

@ThomasWaldmann

This comment has been minimized.

Copy link

ThomasWaldmann commented Jan 8, 2016

@aphirst any docs about the whole procedure?

@aphirst

This comment has been minimized.

Copy link

aphirst commented Jan 9, 2016

@ThomasWaldmann Install instructions for microG here - it's all also on github and FOSS in case you're worried about it being some dodgy XDA homebrew. It mentions either the patch to apply to an Android source tree or the Xposed module to install.

@aphirst

This comment has been minimized.

Copy link

aphirst commented Jan 9, 2016

The only other real longterm option would be to have (Libre?)Signal use something akin to onepf instead of committing to a specific Cloud service. But I think that needs a lot more momentum still. Wrestling control out of Google's hands should be a high priority, especially when the "workarounds" either involve installing proprietary software, or making invasive modifications to your ROMs in light of which many ROM Developers decide to no longer support you.

@rodneyrod

This comment has been minimized.

Copy link

rodneyrod commented Jan 9, 2016

If Libresignal is primarily developed to support GAPPless ROMs through websockets, and Signal calls depend on GCM and proprietary serverside software, then shouldn't the call icon and functionality be stripped from the program?

@mimi89999

This comment has been minimized.

Copy link

mimi89999 commented Jan 9, 2016

@rodneyrod

shouldn't the call icon and functionality be stripped from the program?

Please look at #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment