adding Monetary class' class loader to ServiceLoader's load method #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to fix error in Java11 parallel stream loading error
This was referenced Jun 4, 2020
| @@ -97,7 +98,7 @@ public int getPriority() { | |||
| LOG.log(Level.SEVERE, "could not create services of type: " + serviceType, e); | |||
| } | |||
| try{ | |||
| for(T service:ServiceLoader.load(serviceType)){ | |||
| for(T service:ServiceLoader.load(serviceType, Monetary.class.getClassLoader())){ | |||
There was a problem hiding this comment.
I am not sure if the Java Money implementation will always come from the same class loader as the API. Both classes should be resolvable from the context classloader. And yes, that may cause issues with parallel operations that are executed inside fork join pools. But won't this fix cause issues with deployments where the implementation lives in a separate module (in terms of OSGI or for example JBoss modules)? Or perhaps inside the application itself?
keilw
approved these changes
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to fix error in Java11 parallel stream loading error
This change is