Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: v1.5.0 #59

Merged
merged 2 commits into from
Oct 31, 2023
Merged

release: v1.5.0 #59

merged 2 commits into from
Oct 31, 2023

Conversation

albin3
Copy link
Member

@albin3 albin3 commented Oct 30, 2023

No description provided.

@cctv1005s
Copy link
Collaborator

  1. in test file, the case place holder support and place holder support2 are almost the same, what's the difference between the 2 cases, I mean, maybe place holder support2 is not necessary.

  2. It seems the syntax only support some sql like select ${a} from b rather than select a from ${a}. If that's intentional,, I think you could make it more clear in the README.

@albin3
Copy link
Member Author

albin3 commented Oct 30, 2023

@cctv1005s

  1. place holder support2 put placeholder into quotation, it's testing placeholder feature should not affect normal use of $.

  2. since table_name is an IDENTIFIER, it's not supported yet. Will add this info to readme.

@cctv1005s
Copy link
Collaborator

Okay, lGTM

@albin3 albin3 requested a review from cctv1005s October 31, 2023 02:51
@albin3 albin3 merged commit dec1f54 into master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cctv1005s cctv1005s cctv1005s approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albin3 @cctv1005s