Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#276 fix setUserAgent does not setter #288

Merged
merged 1 commit into from
Oct 31, 2018
Merged

#276 fix setUserAgent does not setter #288

merged 1 commit into from
Oct 31, 2018

Conversation

sirroman
Copy link
Contributor

No description provided.

JayBizzle
JayBizzle reviewed Aug 23, 2018
View reviewed changes
Copy link
Owner

@JayBizzle JayBizzle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crawler-Detect/src/CrawlerDetect.php

Line 89 in 7230d43

$this->userAgent = $this->setUserAgent($userAgent);

Should we change this line to just...

$this->setUserAgent($userAgent);

@sirroman
Copy link
Contributor Author

if I understand correctly your message my answer: no
Because function setUserAgent is public. I use it. But it does nothing.

@JayBizzle
Copy link
Owner

I think you misunderstood.

Line 89 is where we initially set $this->userAgent, but this PR now sets it within the setUserAgent() method, so it is getting set twice for no real reason.

Unless i'm misunderstanding something?!

@JayBizzle JayBizzle merged commit d86328e into JayBizzle:master Oct 31, 2018
@JayBizzle JayBizzle mentioned this pull request Oct 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayBizzle JayBizzle JayBizzle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirroman @JayBizzle