Refactor register combiner code #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
force-pushed
the
psh-cleanup-and-fix-all
branch
from
25577ea
to
a1a645d
Compare
|
I've rebased this on the latest master |
JayFoxRox
commented
Feb 11, 2019
| write_mask, write_mask, write_mask); | ||
| } else { | ||
| assert(ps->flags & PS_COMBINERCOUNT_MUX_MSB); | ||
| qstring_append_fmt(ps->code, "sum_in.%s = mix(ab_in.%s, cd_in.%s, %s(r0.a < 0.5));\n", |
There was a problem hiding this comment.
This check is the wrong way around
dracc
reviewed
Feb 8, 2020
| if (output.muxsum != PS_REGISTER_DISCARD) { | ||
|
|
||
| assert(output.ab_op != PS_COMBINEROUTPUT_AB_DOT_PRODUCT); | ||
| assert(output.cd_op != PS_COMBINEROUTPUT_CD_DOT_PRODUCT); |
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does a lot of smaller changes to bring our implementation closer to NV_register_combiners.
Addressed problems
Clamping in in- and outputsUpstreamedNumber of components for inputs
WTF did I mean by this? vector sizes?
V1R0_SUM flags
Final Combiner G is alphaUpstreamedRe-evaluation of GLSL expressions
Fix broken GLSL in case of MUX, also use correct types and avoid casts if not necessary
Data hazards
Variables might be overwritten before they get used as input because AB, CD and SUM should run in parallel and fill outputs for the next stage.
I've attempted to fix this, but the code is horrible.
This change makes the emulation more accurate and faster.
Many GL errors (possibly conflicting hardware states) are not checked
Someone will eventually have to try each of them.
TODO: