Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line search based on MM, require Julia 1.8 #126

Merged
merged 31 commits into from
Jan 3, 2023
Merged

Add line search based on MM, require Julia 1.8 #126

merged 31 commits into from
Jan 3, 2023

Conversation

JeffFessler
Copy link
Owner

@JeffFessler JeffFessler commented Jan 3, 2023

Perhaps this belongs elsewhere, e.g., LineSearches.jl, or in some "ImageReconOptimizers" but for now this is a convenient place for me to put it.

To reduce carbon footprint, no longer test Julia 1.6.

@JeffFessler JeffFessler changed the title Add line search based on MM Add line search based on MM, require Julia 1.8 Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 100.00% // Head: 99.92% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (41d9df3) compared to base (a2dcd5e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #126      +/-   ##
===========================================
- Coverage   100.00%   99.92%   -0.08%     
===========================================
  Files           37       39       +2     
  Lines         1284     1372      +88     
===========================================
+ Hits          1284     1371      +87     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/utility/downsample.jl 100.00% <ø> (ø)
src/algorithm/general/dot-curv.jl 100.00% <100.00%> (ø)
src/algorithm/general/dot-grad.jl 100.00% <100.00%> (ø)
src/algorithm/general/ls-mm.jl 100.00% <100.00%> (ø)
src/algorithm/general/ncg.jl 100.00% <100.00%> (ø)
src/io/shows.jl 100.00% <100.00%> (ø)
src/algorithm/general/ogm_ls.jl 98.11% <0.00%> (-1.89%) ⬇️
src/MIRT.jl

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JeffFessler JeffFessler merged commit b21f33a into main Jan 3, 2023
@JeffFessler JeffFessler deleted the lsmm branch January 3, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant