Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate tests #47

Merged
merged 7 commits into from
Jul 10, 2020
Merged

Isolate tests #47

merged 7 commits into from
Jul 10, 2020

Conversation

JeffFessler
Copy link
Owner

Prior to this PR, essentially every function in MIRT had a test version that performed a built-in self test.
For example, the Afft function had a method Afft(:test) that would test it.
Having these self tests be part of the src/ code made precompiling unnecessarily slow.
This PR moves all the tests to the 'test/' directory, as is standard in Julia packages.
The directory structure of test/ matches that of src/ so that users can look at the corresponding test code to see concrete examples of how to use the functions. Many of the test functions produce plots or images that serve as mini "demos" of the functions.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #47 into master will decrease coverage by 0.16%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   99.04%   98.87%   -0.17%     
==========================================
  Files          49       48       -1     
  Lines        3348     2223    -1125     
==========================================
- Hits         3316     2198    -1118     
+ Misses         32       25       -7     
Impacted Files Coverage Δ
src/algorithm/general/ncg.jl 100.00% <ø> (ø)
src/algorithm/general/ogm_ls.jl 100.00% <ø> (ø)
src/algorithm/general/pogm_restart.jl 100.00% <ø> (ø)
src/algorithm/general/poweriter.jl 100.00% <ø> (ø)
src/fbp/cuboid_im.jl 100.00% <ø> (ø)
src/fbp/disk-phantom.jl 100.00% <ø> (ø)
src/fbp/ellipse_im.jl 100.00% <ø> (ø)
src/fbp/ellipse_sino.jl 100.00% <ø> (ø)
src/fbp/ellipsoid_im.jl 100.00% <ø> (ø)
src/fbp/rect_im.jl 100.00% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64dbbd0...0645181. Read the comment docs.

@JeffFessler JeffFessler merged commit 80e42ac into master Jul 10, 2020
@JeffFessler JeffFessler deleted the isotest branch July 10, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant