Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "NFFT" to "0.6" #82

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 9, 2020

This pull request changes the compat entry for the NFFT package from 0.5 to 0.5, 0.6.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@JeffFessler JeffFessler force-pushed the compathelper/new_version/2020-12-09-00-50-04-229-3169192266 branch from d1d0398 to 16c483f Compare December 9, 2020 00:50
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #82 (361817c) into master (7cffe83) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   99.87%   99.75%   -0.13%     
==========================================
  Files          49       49              
  Lines        2409     2409              
==========================================
- Hits         2406     2403       -3     
- Misses          3        6       +3     
Impacted Files Coverage Δ
src/nufft/nufft.jl 100.00% <100.00%> (ø)
src/fbp/sino_geom.jl 97.82% <0.00%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cffe83...361817c. Read the comment docs.

@JeffFessler
Copy link
Owner

Also includes changes within to handle breaking changes in NFFT 0.6.

@JeffFessler JeffFessler merged commit ec0f018 into master Dec 9, 2020
@JeffFessler JeffFessler deleted the compathelper/new_version/2020-12-09-00-50-04-229-3169192266 branch December 9, 2020 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant