Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 (releases) deps-dev coming back as analytics #744

Closed
JeromeFitz opened this issue Jul 9, 2022 · 5 comments · Fixed by #1191
Closed

📝 (releases) deps-dev coming back as analytics #744

JeromeFitz opened this issue Jul 9, 2022 · 5 comments · Fixed by #1191

Comments

@JeromeFitz
Copy link
Owner

Something goofy going on with the particular selection of:

📦 Add or update compiled files or packages

Always coming back as:

📈 Add or update analytics or track code

This is probably a good point to determine if it is because of the index selection on the emoji find, or if this in general could be greatly reduced in complexity by moving back to a json file (that can be dynamically generated) instead of a dynamically created object of information. Instead of trying to finagle a way to add to release.config.cjs or other configuration files, may be ideal to just allow for a json file swap with some examples. I think it would make things much smaller in general.

Could also help with a potential adoption if we can use this is a jumping point RE: #729

@ygorluiz
Copy link

@JeromeFitz I think you would like to know this lib vanilla-extract
I think stitches is almost dying or even already died 🔥

@JeromeFitz
Copy link
Owner Author

🤔 Even weirder, it is only when renovate is the author of the commit:

Thanks for sharing about vanilla-extract @ygorluiz

With Next 13, re-looking at how they prefer styling to take place. May make the move depending on how the next few weeks play out with them. As right now using stitches (or vanilla) you cannot migrate to the ./app system away from ./pages

@ygorluiz
Copy link

get ready Next.js 13 upgrade guide

@JeromeFitz
Copy link
Owner Author

🎉 Exciting times indeed.

This is the call-out about stitches to be aware of currently:

@JeromeFitz
Copy link
Owner Author

More than likely going to move back to tailwind w/ radix-ui sometime over the next few months for the design-system to take advantaged of Next 13 fully.

The original intent of this issue is going to be looked at again soon-ish with the release of 🎉 ccommit

  • Probably in Q1

@kodiakhq kodiakhq bot closed this as completed in #1191 Jan 29, 2024
kodiakhq bot added a commit that referenced this issue Jan 29, 2024
- [x] 📦️  NICE-70 update `dep-up` to patch [skip ci]
- [x] ♻️  (esm) NICE-70 add missing `.js` [skip ci]
- [x] 🐛  NICE-70 dizzy to animation rewrite [b]


Closes #744
@JeromeFitz JeromeFitz reopened this May 21, 2024
kodiakhq bot added a commit that referenced this issue Jun 23, 2024
Since these are all intertwined, do them all at once and upgrade accordingly.

## Packages

### Upgrade

- [x] semantic-release@24
  - <https://semantic-release.gitbook.io/semantic-release>
  - <https://github.com/semantic-release/semantic-release>
- [x] @semantic-release/commit-analyzer@13
  - <https://github.com/semantic-release/commit-analyzer>
- [x] conventional-commits-parser@6
  - <https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-commits-parser>
- [x] conventional-commits-filter@5
  - <https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-commits-filter>

### Remove

- ~~@semantic-release/git~~ (Keep)
- [x] @semantic-release/github
- [x] @semantic-release/npm
- [x] @semantic-release/release-notes-generator
- [x] semantic-release-commit-filter

Still have the issue with #744 but put in some better (commented out for now) debugging to finally figure this out.

Not _100%_ sure that every package now doesn't just grip _every_ commit across the monorepo, but we will see. There are worse things I guess. And **changesets** seems to ... you know what I will stop there. 😂
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants