-
Notifications
You must be signed in to change notification settings - Fork 99
Run pre-merge PR checks on GitHub Actions #2414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jb-main
Are you sure you want to change the base?
Conversation
26b78ab
to
4099ef0
Compare
4099ef0
to
1cae97c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objections
82fc767
to
a9ed1f2
Compare
9007a7b
to
284574d
Compare
|
||
- name: Building Framework with XCTests | ||
run: | | ||
./gradlew :compose:ui:ui:linkInstrumentedTestDebugFrameworkUikitSimArm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
compose-ios-utils-tests: | ||
runs-on: macos-15-xlarge | ||
name: Compose iOS Utils Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,205 @@ | |||
name: Compose Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List of potential flaky failures (failed once on this PR):
- ios Utils testFullscreenPresentationOnTop https://github.com/JetBrains/compose-multiplatform-core/actions/runs/18222972247/job/51887006028?pr=2414
- changesMustBeAppliedDespiteConstantDebounceAfter1Second
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential automation: CMP-9022 Flaky test detector and disabler
paths: "**/reports/junit.xml" | ||
if: always() | ||
|
||
compose-web-chrome-tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web tests constantly fail now:
https://github.com/JetBrains/compose-multiplatform-core/actions/runs/18222972247/job/51887006066?pr=2414
|
||
compose-ios-instrumented-tests: | ||
runs-on: macos-15-xlarge | ||
name: Compose iOS Instrumented Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It adds all pre-merge checks that we currently have in TeamCity to GitHub Actions.
CMP-8945 Run web tests with the latest and the minimal supported version of browsers
CMP-8136 PR checks runs always by main teamcity config
CMP-5663 Run TeamCity automatically on user PR's after pressing "Approve and Run"
Ignored flaky tests (with TODO and follow-up tasks):
SkikoParagraphTest
on WebSkiaParagraphIntrinsicsTest
on WebStringTest.directionality
on WebWindowTest > undecorated resizable window with unspecified size
on DesktopRelease Notes
N/A