Skip to content

Conversation

MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Sep 18, 2025

It adds all pre-merge checks that we currently have in TeamCity to GitHub Actions.

CMP-8945 Run web tests with the latest and the minimal supported version of browsers
CMP-8136 PR checks runs always by main teamcity config
CMP-5663 Run TeamCity automatically on user PR's after pressing "Approve and Run"

Ignored flaky tests (with TODO and follow-up tasks):

  • SkikoParagraphTest on Web
  • SkiaParagraphIntrinsicsTest on Web
  • StringTest.directionality on Web
  • WindowTest > undecorated resizable window with unspecified size on Desktop

Release Notes

N/A

@MatkovIvan MatkovIvan force-pushed the ivan.matkov/pr-gha-checks branch 12 times, most recently from 26b78ab to 4099ef0 Compare September 18, 2025 14:23
@MatkovIvan MatkovIvan changed the title CI checks experiment Run pre-merge PR checks in GitHub Actions Sep 18, 2025
@MatkovIvan MatkovIvan force-pushed the ivan.matkov/pr-gha-checks branch from 4099ef0 to 1cae97c Compare September 18, 2025 14:33
Copy link

@Schahen Schahen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections

@MatkovIvan MatkovIvan force-pushed the ivan.matkov/pr-gha-checks branch 7 times, most recently from 82fc767 to a9ed1f2 Compare September 18, 2025 18:41
@MatkovIvan MatkovIvan marked this pull request as ready for review September 18, 2025 19:02
@MatkovIvan MatkovIvan requested review from kropp and igordmn September 18, 2025 19:02
@MatkovIvan MatkovIvan changed the title Run pre-merge PR checks in GitHub Actions Run pre-merge PR checks on GitHub Actions Sep 18, 2025
@MatkovIvan MatkovIvan force-pushed the ivan.matkov/pr-gha-checks branch from 9007a7b to 284574d Compare October 2, 2025 14:11

- name: Building Framework with XCTests
run: |
./gradlew :compose:ui:ui:linkInstrumentedTestDebugFrameworkUikitSimArm64
Copy link
Collaborator

@igordmn igordmn Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove .jb-ciscripts and check if the issue doesn't exist with GitHub Actions.

@ASalavei, how can we check that the issue doesn't exist?


compose-ios-utils-tests:
runs-on: macos-15-xlarge
name: Compose iOS Utils Tests
Copy link
Collaborator

@igordmn igordmn Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,205 @@
name: Compose Tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of potential flaky failures (failed once on this PR):

Copy link
Collaborator

@igordmn igordmn Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential automation: CMP-9022 Flaky test detector and disabler

paths: "**/reports/junit.xml"
if: always()

compose-web-chrome-tests:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


compose-ios-instrumented-tests:
runs-on: macos-15-xlarge
name: Compose iOS Instrumented Tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants