Update gradle plugin: Deprecate experimental configuration for Compose for Web #4796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for Web Since 1.6.10 Compose for Web goes to Alpha and experimental configuration is not needed anymore. We'll do it by default.
eymar
commented
May 10, 2024
| @@ -27,7 +27,6 @@ private val TargetType.gradlePropertyName get() = "org.jetbrains.compose.experim | |||
| private val EXPERIMENTAL_TARGETS: Set<TargetType> = setOf( | |||
| TargetType("macos", presets = listOf("macosX64", "macosArm64")), | |||
| TargetType("jscanvas", presets = listOf("jsIr", "js")), | |||
| TargetType("wasm", presets = listOf("wasm", "wasmJs")), | |||
There was a problem hiding this comment.
Note: I keep jscanvas above!
We'll try to support k/js target of CM at least until Safari enables WasmGC. But still, it's better to keep it as an experimental target for now.
Schahen
approved these changes
May 10, 2024
igordmn
approved these changes
May 13, 2024
eymar
added a commit
that referenced
this pull request
May 13, 2024
…e for Web (#4796) Since 1.6.10 Compose for Web goes to Alpha and experimental configuration is not needed anymore. We'll configure the web targets by default when they're added to projects. ## Testing - I built the plugin to mavenLocal. And used it in a couple of our samples. - After gradle sync completes, I observe the Deprecation warning in build.gradle.kts on `compose.experimental.web` usages (see a screenshot below) <img width="1022" alt="Screenshot 2024-05-10 at 15 41 14" src="https://github.com/JetBrains/compose-multiplatform/assets/7372778/e8ede073-8d34-4dd7-ae74-c83ca0ff5c96"> Then I remove deprecated API usages and test that the project works without it: - run `./gradlew clean` just in case - run the app: `./gradlew wasmJsBrowserRun` and `./gradlew jsBrowserRun` - both run fine - build the production distribution: `./gradlew wasmJsBrowserDistribution` - `cd ..../build/dist/wasmJs/productionExecutable` and run `python -m http.server`, open a browser at `http://localhost:8000` - the app should work the same way it works with gradle tasks above <!-- Optional --> This should be tested by QA ## Release Notes ### Highlights - Web - Compose for Web goes to Alpha! Some experimental Compose Multiplatform Gradle plugin APIs for web app configuration were deprecated. Their usage is not required anymore. (cherry picked from commit 885ea3d)
eymar
added a commit
that referenced
this pull request
May 17, 2024
…ed (#4824) Fixes: #4823 In #4796 we intentionally started to configure the web app for all k/js and k/wasm targets. The configuration involves adding a dependency on skiko-wasm runtime and unpacking it. Some projects don't need skiko-wasm-runtime (like those based on compose.html or just compose.runtime). **Solution:** We check if there is a dependency on org.jetbrains.compose.ui libraries (including transitive dependencies). If we find it, then we enable skikoUnpack task. Otherwise it's disabled. ## Testing - Build the gradle plugin locally (with this change) - Used it in our html landing example: https://github.com/JetBrains/compose-multiplatform/blob/master/examples/html/landing - Run `./gradlew jsBrowserDistribution`, check `.../compose-multiplatform/examples/html/landing/build/dist/js/productionExecutable` and see NO skiko.* files added there - Then add `implementation(compose.foundation)` dependency in build.gradle.jts and run `./gradlew clean jsBrowserDistribution` again - the build/dist contains skiko.* now
eymar
added a commit
that referenced
this pull request
May 17, 2024
…ed (#4824) Fixes: #4823 In #4796 we intentionally started to configure the web app for all k/js and k/wasm targets. The configuration involves adding a dependency on skiko-wasm runtime and unpacking it. Some projects don't need skiko-wasm-runtime (like those based on compose.html or just compose.runtime). **Solution:** We check if there is a dependency on org.jetbrains.compose.ui libraries (including transitive dependencies). If we find it, then we enable skikoUnpack task. Otherwise it's disabled. ## Testing - Build the gradle plugin locally (with this change) - Used it in our html landing example: https://github.com/JetBrains/compose-multiplatform/blob/master/examples/html/landing - Run `./gradlew jsBrowserDistribution`, check `.../compose-multiplatform/examples/html/landing/build/dist/js/productionExecutable` and see NO skiko.* files added there - Then add `implementation(compose.foundation)` dependency in build.gradle.jts and run `./gradlew clean jsBrowserDistribution` again - the build/dist contains skiko.* now (cherry picked from commit 30164c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.6.10 Compose for Web goes to Alpha and experimental configuration is not needed anymore. We'll configure the web targets by default when they're added to projects.
Testing
compose.experimental.webusages (see a screenshot below)Then I remove deprecated API usages and test that the project works without it:
./gradlew cleanjust in case./gradlew wasmJsBrowserRunand./gradlew jsBrowserRun- both run fine./gradlew wasmJsBrowserDistributioncd ..../build/dist/wasmJs/productionExecutableand runpython -m http.server, open a browser athttp://localhost:8000- the app should work the same way it works with gradle tasks aboveThis should be tested by QA
Release Notes
Highlights - Web