Add cmake_common_scripts #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Armstrong
force-pushed
the
feature/CMakeCommonScripts
branch
7 times, most recently
from
a0cc773
to
420f098
Compare
Levi-Armstrong
force-pushed
the
feature/CMakeCommonScripts
branch
3 times, most recently
from
7564899
to
44fcae3
Compare
Levi-Armstrong
force-pushed
the
feature/CMakeCommonScripts
branch
from
44fcae3
to
3f04047
Compare
Levi-Armstrong
force-pushed
the
feature/CMakeCommonScripts
branch
from
6357b5e
to
68255e4
Compare
|
@mpowelson Ready for review. |
mpowelson
reviewed
Jul 9, 2020
Comment on lines
9
to
11
| if(NOT EIGEN3_INCLUDE_DIRS) | ||
| set(EIGEN3_INCLUDE_DIRS ${EIGEN3_INCLUDE_DIR}) | ||
| endif() |
There was a problem hiding this comment.
What is this? You're allowed to overwrite the version of Eigen found by CMake?
There was a problem hiding this comment.
I believe this is just making sure the variable EIGEN3_INCLUDE_DIRS exists and if not it sets it to EIGEN3_INCLUDE_DIR. They should be the same but I believe older versions may have only had EIGEN3_INCLUDE_DIR which was an error in Eigen.
mpowelson
approved these changes
Jul 9, 2020
|
@mpowelson I fixed the requested changes. Also I create tag v0.1.0 and increased the version to 0.2.0 since this adds a news dependency. |
|
Ok. It looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.