support sending ActorAddress objects #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
More or less what the title says. This PR adds the proto messages and necessary trait implementations to send an
ActorAddress(or a slice of them) as abusan::message::Message.In theory this means they can be serialized and shared across process boundaries, but in reality that would require a bit more work as nothing other than the "local" scheme is supported at the moment.
Motivation
Sharing addresses unlocks more dynamic messaging patterns as currently it's only possible to send messages between parents and children.
Test Plan
Nothing ATM. Work on load balancing will make use of and test this further.