Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gv files provider waffle #212

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Johnetordoff
Copy link
Owner

@Johnetordoff Johnetordoff commented May 9, 2024

Purpose

Allows us to feature flip between our current system and the new GravyValet addon service. Should change files related routes to use new set up.

Changes

  • new get_addon functions for AbstractNode and OsfUser waffled to return mock config
  • creates mock config GravyValetAddonAppConfig to serve as addon proxy object
  • add tests and modifes some existing for new mocks

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

@Johnetordoff Johnetordoff force-pushed the gv-files-provider-waffle branch 14 times, most recently from 293e89a to 221248b Compare May 13, 2024 13:26
 into gv-files-provider-waffle

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  [ENG-5140] #2 Update get_auth for GV and readability  (CenterForOpenScience#10613)
@Johnetordoff Johnetordoff force-pushed the gv-files-provider-waffle branch 2 times, most recently from 375673b to 074878f Compare May 13, 2024 18:07
@Johnetordoff Johnetordoff force-pushed the gv-files-provider-waffle branch 5 times, most recently from c7606c9 to dc4cda4 Compare May 16, 2024 19:35
@Johnetordoff Johnetordoff force-pushed the gv-files-provider-waffle branch 2 times, most recently from 7a55c02 to 9f0d6e4 Compare May 22, 2024 21:05
@Johnetordoff Johnetordoff force-pushed the gv-files-provider-waffle branch 7 times, most recently from 647f35c to 06cf8fe Compare May 23, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant