Warning SVN not found. Install it or configure it using the 'svn.path' setting.

[Yanpas]

• VSCode Version: 1.28
• OS Version: kubuntu 18.04
• Extension Version: 1.44
• System Language:
• SVN Version: 1.9.7

Issue

Sometimes after reloading vscode window (after extensions update) I see following warning:

SVN not found. Install it or configure it using the 'svn.path' setting.

The folder which I'm opening doesn't contain svn repository, only git.

Steps to Reproduce

SVN Output

Paste here content of "View >> Output >> OUTPUT >> SVN"

Screenshots

[JohnstonCode]

I'm also getting this when debugging sometimes.

[Yanpas]

Seems like a regression, didn't notice it a couple weeks ago or earlier

[edgardmessias]

@JohnstonCode , what your OS version?
Here with Windows 10 never showed the warning

[JohnstonCode]

i get it on Fedora 27

[edgardmessias]

Need check the https://github.com/JohnstonCode/svn-scm/blob/master/src/svnFinder.ts#L123

[Yanpas]

The issues is in checkSvnCommand. Seems like some synchronization issues in cp module. If I add console.error - then buffers are calculated succesfully every time. On the screenshot the are empty

[Yanpas]

I guess "exit" handler may be called before "data" handler, so that leads to this behavior. This issue is unreprodicible if I introduce too much breakpoints

[Yanpas]

According to docs signal exit should be replaced with close, since close is emmited when all streams are closed. Tested - it helps. I'll open a PR

[JohnstonCode]

🎉 This issue has been resolved in version 1.44.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀