Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Replace prettier "**/*" --ignore-unknown with prettier . #1218

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 9, 2024 · 1 comment · Fixed by #1250
Closed
3 tasks done

🛠 Tooling: Replace prettier "**/*" --ignore-unknown with prettier . #1218

JoshuaKGoldberg opened this issue Jan 9, 2024 · 1 comment · Fixed by #1250
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Milestone
General Simplific...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Per https://prettier.io/blog/2023/11/13/3.1.0#process-files-only-supported-by-plugins-15433httpsgithubcomprettierprettierpull15433-by-sosukesuzukihttpsgithubcomsosukesuzuki:

You can replace prettier "**/*" --ignore-unknown with prettier . since they are equivalent now.

Great! Always love a simplification 😄. Let's do that in this repo's package.json.

Additional Info

Noted to me by @fisker in prettier/prettier#15898 (comment). Thanks! 🙌
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the General Simplification milestone Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the type: cleanup Tech debt or other code/repository cleanups label Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 16, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 16, 2024
@JoshuaKGoldberg
chore: use prettier . (#1250)
7793c80 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1218
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Directly replaces `prettier "**/*" --ignore-unknown` with `prettier .`
per Prettier's blog post.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.54.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
General Simplification
Development

Successfully merging a pull request may close this issue.

chore: use prettier . JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg