Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Don't create src/*.ts files during migration #749

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 2, 2023 · 1 comment · Fixed by #841
Closed
3 tasks done

🐛 Bug: Don't create src/*.ts files during migration #749

JoshuaKGoldberg opened this issue Sep 2, 2023 · 1 comment · Fixed by #841
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Migrating an existing repository (--mode migrate) generally doesn't need to create greet-related files (src/greet.ts, etc.). But that doesn't make much sense for a repository that likely already has code.

Actual

Right now, if you run --mode migrate in an existing repository that has src/index.ts, the file will get replaced with the default src/index.ts, src/greet.test.ts, etc.

Let's skip creating greet-related files during migration.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Sep 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 4, 2023
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 19, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Sep 19, 2023
@JoshuaKGoldberg
fix: don't create src/ files during --mode migrate (#841)
dd2392a 
## PR Checklist

- [x] Addresses an existing open issue: fixes #749
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Passes in the root `mode` to `writeStructure` -> `createStructure` so it
knows not to call `createSrc` during migration.
@github-actions
Copy link

🎉 This is included in version v1.29.44 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

fix: don't create src/ files during --mode migrate JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg