Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: lint-packages.yml isn't created in setup #752

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 2, 2023 · 1 comment · Fixed by #840
Closed
3 tasks done

🐛 Bug: lint-packages.yml isn't created in setup #752

JoshuaKGoldberg opened this issue Sep 2, 2023 · 1 comment · Fixed by #840
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

This template includes a lint:packages script to run pnpm dedupe --check. A .github/workflows/lint-packages.yml file runs it in CI. That file should be created in setup.

Actual

It doesn't look like it is. An oversight on my side, most likely.

Let's add the missing lint-packages script during setup.

Additional Info

See https://github.com/JoshuaKGoldberg/create-typescript-app/blob/b9f7dbb7750d9b3db0dd0517ddb15c706835838c/src/steps/writing/creation/dotGitHub/workflows.ts for where other workflow files are created.

Note that the lint-packages.yml file shouldn't be created if options.excludeLintPackages is true.
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Sep 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 19, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Sep 19, 2023
@JoshuaKGoldberg
fix: correct key for excluding lint-packages.yml (#840)
09dbd39 
## PR Checklist

- [x] Addresses an existing open issue: fixes #752
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Turns out it'd been using the wrong excludes key.
@github-actions
Copy link

🎉 This is included in version v1.29.43 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

fix: correct key for excluding lint-packages.yml JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg