-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port README.md badge underlines fix to templates #1038
feat: port README.md badge underlines fix to templates #1038
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
- Coverage 94.15% 94.14% -0.02%
==========================================
Files 95 95
Lines 5454 5444 -10
Branches 436 436
==========================================
- Hits 5135 5125 -10
Misses 318 318
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great start! One bug around the repo's template mismatching the .all-contributorsrc
badge template, but this is the right direction. Thanks! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @5hraddha!
There are some existing inconsistencies in the README.md that make me not super motivated to try to get it all exactly the same. If anybody finds them irksome they can always file an issue. But this PR more than adequately solves for the case of the badge underlines in the template.
🎉 This is included in version v1.45.0 🎉 The release is available on: Cheers! 📦🚀 |
Thank you! @JoshuaKGoldberg . If there is anything specific you want to resolve from the existing inconsistencies, please feel free to let me know. I can meddle with it sometime after the weekend. Have a great day! |
You got it! There were really two things I was thinking of:
|
PR Checklist
status: accepting prs
Overview
This PR ports README.md badge underlines fix (in #1030) to templates that generates the badges in README.md files and its associated test. 💖